feat: drop separate status db copies in workdir - #3602
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the extra “workdir copy” of cluster-management status SQLite databases and instead relies on the copies already present in testing_artifacts/ (and testing_artifacts.tar.xz). It also updates the failure-analysis prompts and CI artifact lists to point to the databases inside testing_artifacts/pytest-*/cm-status.db.
Changes:
- Delete
runner/status_dbs.shand stop copyingcm-status-*.db*intorun_workdir/. - Update regression/upgrade runner scripts and reusable workflows to stop uploading
cm-status-*.db*in thetestrun-filesartifact. - Update failure-analysis prompt templates to reference
testing_artifacts/pytest-*/cm-status.dbinstead ofcm-status-N.db.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| runner/status_dbs.sh | Removes the standalone script that copied status DBs into the workdir. |
| runner/regression.sh | Stops invoking status_dbs.sh; relies on testing_artifacts only. |
| runner/node_upgrade.sh | Stops invoking status_dbs.sh; always saves testing_artifacts at end. |
| agent_docs/upgrade_failure_analysis_prompt.md | Points analysts to testing_artifacts/pytest-*/cm-status.db and explains ordering by mtime. |
| agent_docs/failure_analysis_prompt.md | Points analysts to testing_artifacts/pytest-*/cm-status.db. |
| .github/workflows/upgrade_reusable.yaml | Removes cm-status-*.db* from testrun-files artifact upload. |
| .github/workflows/regression_reusable.yaml | Removes cm-status-*.db* from testrun-files artifact upload. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The status database of each pytest run is included in the testing_artifacts dir (and in the testing_artifacts.tar.xz artifact) together with the rest of the pytest temp dir content, so there is no need to copy the databases separately to the workdir and upload them in the testrun-files artifact. Point the failure analysis prompts to the database copies in the testing_artifacts dir.
mkoura
force-pushed
the
rm_status_db_copy
branch
from
August 11, 2026 12:15
4d1a308 to
5124a3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The status database of each pytest run is included in the testing_artifacts dir (and in the testing_artifacts.tar.xz artifact) together with the rest of the pytest temp dir content, so there is no need to copy the databases separately to the workdir and upload them in the testrun-files artifact. Point the failure analysis prompts to the database copies in the testing_artifacts dir.