Skip to content

Remove x86_64-darwin from release-upload workflow - #1411

Open
Jimbo4350 wants to merge 1 commit into
masterfrom
jm/release-upload-drop-x86_64-darwin
Open

Remove x86_64-darwin from release-upload workflow#1411
Jimbo4350 wants to merge 1 commit into
masterfrom
jm/release-upload-drop-x86_64-darwin

Conversation

@Jimbo4350

Copy link
Copy Markdown
Contributor

Changelog

- description: |
    Remove x86_64-darwin from the release-upload workflow; support for it was dropped from the flake in 26b9be512
  type:
    # - feature        # introduces a new feature
    # - breaking     # the API has changed in a breaking way
    # - compatible   # the API has changed but is non-breaking
    # - optimisation # measurable performance improvements
    # - refactoring  # QoL changes
    # - bugfix       # fixes a defect
    # - test         # fixes/modifies tests
    - maintenance  # not directly related to the code
    # - release      # related to a new release preparation
    # - documentation # change in code docs, haddocks...

Context

Commit 26b9be5 ("drop support for x86_64-darwin", April 2026) removed x86_64-darwin from the flake's supportedSystems, but the Release Upload workflow still listed it in its download matrix. Every run since then fails in Download Asset (x86_64-darwin) with:

error: flake '...' does not provide attribute 'hydraJobs.x86_64-darwin.packages.cardano-cli:exe:cardano-cli'

which cancels the remaining downloads and skips Create Release. This is why there is no GitHub release for 11.1.0.0 (run 26503541162 and the re-run 31538755892 both failed this way), and it would break the upcoming 11.2.0.0 upload as well.

This removes x86_64-darwin from the matrix, the tar/checksum loops, and the release file list.

How to trust this PR

Compare with supportedSystems in flake.nix (x86_64-linux, aarch64-linux, aarch64-darwin) plus the win64 cross-build. After merging, gh workflow run "Release Upload" -f target_tag=cardano-cli-11.1.0.0 (and the same for 11.2.0.0) should succeed and publish the GitHub releases.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Self-reviewed the diff

Support for x86_64-darwin was dropped from the flake in 26b9be5, but
the release-upload workflow still tried to download a hydra build for
it, which has made every release upload since 11.1.0.0 fail before
creating the GitHub release.
@Jimbo4350
Jimbo4350 requested a review from a team as a code owner August 11, 2026 21:41
Copilot AI lite review requested due to automatic review settings August 11, 2026 21:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GitHub Actions “Release Upload” workflow to stop attempting to download and publish x86_64-darwin artifacts, aligning the workflow’s matrix with the flake’s supportedSystems (which no longer includes x86_64-darwin).

Changes:

  • Remove x86_64-darwin from the workflow download matrix.
  • Update the tarball and checksum generation loops to exclude x86_64-darwin.
  • Remove the x86_64-darwin tarball from the release asset upload list.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants