Remove x86_64-darwin from release-upload workflow - #1411
Open
Jimbo4350 wants to merge 1 commit into
Open
Conversation
Support for x86_64-darwin was dropped from the flake in 26b9be5, but the release-upload workflow still tried to download a hydra build for it, which has made every release upload since 11.1.0.0 fail before creating the GitHub release.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Actions “Release Upload” workflow to stop attempting to download and publish x86_64-darwin artifacts, aligning the workflow’s matrix with the flake’s supportedSystems (which no longer includes x86_64-darwin).
Changes:
- Remove
x86_64-darwinfrom the workflow download matrix. - Update the tarball and checksum generation loops to exclude
x86_64-darwin. - Remove the
x86_64-darwintarball from the release asset upload list.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
carbolymer
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Commit 26b9be5 ("drop support for x86_64-darwin", April 2026) removed
x86_64-darwinfrom the flake'ssupportedSystems, but theRelease Uploadworkflow still listed it in its download matrix. Every run since then fails inDownload Asset (x86_64-darwin)with:which cancels the remaining downloads and skips
Create Release. This is why there is no GitHub release for 11.1.0.0 (run 26503541162 and the re-run 31538755892 both failed this way), and it would break the upcoming 11.2.0.0 upload as well.This removes
x86_64-darwinfrom the matrix, the tar/checksum loops, and the release file list.How to trust this PR
Compare with
supportedSystemsinflake.nix(x86_64-linux, aarch64-linux, aarch64-darwin) plus the win64 cross-build. After merging,gh workflow run "Release Upload" -f target_tag=cardano-cli-11.1.0.0(and the same for 11.2.0.0) should succeed and publish the GitHub releases.Checklist