You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Restores the #1362 regression test that #1366 was supposed to add. Although #1366 is marked merged (merge commit 21da415), its auto-merge silently dropped all four artifacts of the test when resolving the Testing/CMakeLists.txt conflict against master:
the iccdev.issue-1362-v5dspobs-xyztype-regressioniccdev_add_script_test() registration
Master currently has the #1364 producer fix (CIccTagXYZ) and the #1356/#1361 tests, but no #1362 test — so the rXYZ/gXYZ/bXYZ XYZType fix has no regression guard. This branch (fix-rev-1362, prepared by @xsscx) re-adds exactly those four pieces.
Why this matters
The test runs iccV5DspObsToV4Dsp on the committed V5 display + observer inputs and inspects the on-disk type signature of each matrix-column tag, failing if any is still 'sf32' (s15Fixed16ArrayType, 73663332) instead of 'XYZ ' (XYZType, 58595a20). Without it, a regression of #1362 would land unnoticed.
github-actionsBot
added
Testing
CTest, regression, or test coverage
Scripts
Shell, PowerShell, or repository automation scripts
Configuration
Repository, CMake, YAML, JSON, or tool configuration
Build
Build system, CMake, compiler, or packaging
Unix
Linux, macOS, Bash, or POSIX shell scope
failed
One or more CI checks failed
labels
Jun 15, 2026
2026-06-15 22:44:01 UTC
Note - Removed the Fail Label the Bot added. Need to Research. I watched the PR open, and ci-pr-action is running and does not indicate any failure, nor do any sibling workflows.
Why this PR existed:#1366 is marked merged (21da415), but its auto-merge silently dropped all four #1362 test artifacts when resolving the Testing/CMakeLists.txt conflict against master — the regression script, both .icc fixtures, and the CTest registration. So the #1364 producer fix (rXYZ/gXYZ/bXYZ → CIccTagXYZ / 'XYZ ') had shipped to master without a regression guard. (Full timeline on #1366.)
the iccdev.issue-1362-v5dspobs-xyztype-regressioniccdev_add_script_test() registration — with its closing ) (paren balance verified)
Verified post-merge on master: all four pieces present, exactly one#1362 registration (no duplicate), CMakeLists.txt parens balanced, 30 checks green / 0 fail. The test runs iccV5DspObsToV4Dsp on the committed inputs and fails if any matrix-column tag is still 'sf32' (73663332) instead of 'XYZ ' (58595a20).
The #1362 thread is now fully closed: fix #1364 + test #1368. Thanks @xsscx for the fix-rev-1362 restore branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BuildBuild system, CMake, compiler, or packagingConfigurationRepository, CMake, YAML, JSON, or tool configurationpendingCI checks still runningScriptsShell, PowerShell, or repository automation scriptsTestingCTest, regression, or test coverageUnixLinux, macOS, Bash, or POSIX shell scope
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Restores the #1362 regression test that #1366 was supposed to add. Although #1366 is marked merged (merge commit
21da415), its auto-merge silently dropped all four artifacts of the test when resolving theTesting/CMakeLists.txtconflict against master:.github/scripts/iccdev-issue-1362-v5dspobs-xyztype-regression.sh.github/ci/test-data/v5dspobs-lcddisplay.icc(fixture).github/ci/test-data/v5dspobs-cat8lab.icc(fixture)iccdev.issue-1362-v5dspobs-xyztype-regressioniccdev_add_script_test()registrationMaster currently has the #1364 producer fix (
CIccTagXYZ) and the #1356/#1361 tests, but no #1362 test — so the rXYZ/gXYZ/bXYZ XYZType fix has no regression guard. This branch (fix-rev-1362, prepared by @xsscx) re-adds exactly those four pieces.Why this matters
The test runs
iccV5DspObsToV4Dspon the committed V5 display + observer inputs and inspects the on-disk type signature of each matrix-column tag, failing if any is still'sf32'(s15Fixed16ArrayType,73663332) instead of'XYZ '(XYZType,58595a20). Without it, a regression of #1362 would land unnoticed.Notes
#1362iccdev_add_script_test()block is restored with its closing)(paren balance verified); the dropped paren in the earlier Test: regression for iccV5DspObsToV4Dsp rXYZ/gXYZ/bXYZ tag type (#1362) #1366 merge was the root of theParse error. Function missing ending ")"configure failure..github/scripts/ CodeQL / CI changes live on an upstream branch.🤖 Generated with Claude Code