Skip to content

Restore: #1362 regression test dropped by #1366 auto-merge (script + fixtures + CTest registration)#1368

Merged
xsscx merged 1 commit into
masterfrom
fix-rev-1362
Jun 15, 2026
Merged

Restore: #1362 regression test dropped by #1366 auto-merge (script + fixtures + CTest registration)#1368
xsscx merged 1 commit into
masterfrom
fix-rev-1362

Conversation

@colourbill-ctrl

Copy link
Copy Markdown
Contributor

What

Restores the #1362 regression test that #1366 was supposed to add. Although #1366 is marked merged (merge commit 21da415), its auto-merge silently dropped all four artifacts of the test when resolving the Testing/CMakeLists.txt conflict against master:

  • .github/scripts/iccdev-issue-1362-v5dspobs-xyztype-regression.sh
  • .github/ci/test-data/v5dspobs-lcddisplay.icc (fixture)
  • .github/ci/test-data/v5dspobs-cat8lab.icc (fixture)
  • the iccdev.issue-1362-v5dspobs-xyztype-regression iccdev_add_script_test() registration

Master currently has the #1364 producer fix (CIccTagXYZ) and the #1356/#1361 tests, but no #1362 test — so the rXYZ/gXYZ/bXYZ XYZType fix has no regression guard. This branch (fix-rev-1362, prepared by @xsscx) re-adds exactly those four pieces.

Why this matters

The test runs iccV5DspObsToV4Dsp on the committed V5 display + observer inputs and inspects the on-disk type signature of each matrix-column tag, failing if any is still 'sf32' (s15Fixed16ArrayType, 73663332) instead of 'XYZ ' (XYZType, 58595a20). Without it, a regression of #1362 would land unnoticed.

Notes

🤖 Generated with Claude Code

@github-actions github-actions Bot added Testing CTest, regression, or test coverage Scripts Shell, PowerShell, or repository automation scripts Configuration Repository, CMake, YAML, JSON, or tool configuration Build Build system, CMake, compiler, or packaging Unix Linux, macOS, Bash, or POSIX shell scope failed One or more CI checks failed labels Jun 15, 2026

@xsscx xsscx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2026-06-15 22:38:35 UTC

@xsscx xsscx enabled auto-merge (squash) June 15, 2026 22:38
@xsscx xsscx removed the failed One or more CI checks failed label Jun 15, 2026
@xsscx

xsscx commented Jun 15, 2026

Copy link
Copy Markdown
Member

TODO @xsscx

2026-06-15 22:44:01 UTC
Note - Removed the Fail Label the Bot added. Need to Research. I watched the PR open, and ci-pr-action is running and does not indicate any failure, nor do any sibling workflows.

@github-actions github-actions Bot added the pending CI checks still running label Jun 15, 2026
@xsscx xsscx merged commit 00f04e1 into master Jun 15, 2026
56 of 57 checks passed
@colourbill-ctrl

Copy link
Copy Markdown
Contributor Author

Merged — #1362 regression test restored on master

Confirming the close-out for the archive.

Why this PR existed: #1366 is marked merged (21da415), but its auto-merge silently dropped all four #1362 test artifacts when resolving the Testing/CMakeLists.txt conflict against master — the regression script, both .icc fixtures, and the CTest registration. So the #1364 producer fix (rXYZ/gXYZ/bXYZ → CIccTagXYZ / 'XYZ ') had shipped to master without a regression guard. (Full timeline on #1366.)

What landed here (00f04e1):

  • .github/scripts/iccdev-issue-1362-v5dspobs-xyztype-regression.sh
  • .github/ci/test-data/v5dspobs-lcddisplay.icc, .github/ci/test-data/v5dspobs-cat8lab.icc
  • the iccdev.issue-1362-v5dspobs-xyztype-regression iccdev_add_script_test() registration — with its closing ) (paren balance verified)

Verified post-merge on master: all four pieces present, exactly one #1362 registration (no duplicate), CMakeLists.txt parens balanced, 30 checks green / 0 fail. The test runs iccV5DspObsToV4Dsp on the committed inputs and fails if any matrix-column tag is still 'sf32' (73663332) instead of 'XYZ ' (58595a20).

The #1362 thread is now fully closed: fix #1364 + test #1368. Thanks @xsscx for the fix-rev-1362 restore branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build Build system, CMake, compiler, or packaging Configuration Repository, CMake, YAML, JSON, or tool configuration pending CI checks still running Scripts Shell, PowerShell, or repository automation scripts Testing CTest, regression, or test coverage Unix Linux, macOS, Bash, or POSIX shell scope

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants