Skip to content

Use a dedicated Node build stage so Dependabot can manage Node version via Docker updates #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenjaminMichaelis merged 3 commits into from
Aug 12, 2026
Merged

Use a dedicated Node build stage so Dependabot can manage Node version via Docker updates #409

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7075986
Use dedicated Node stage for JS Docker build
Copilot Aug 12, 2026
700885c
Use dedicated Node stage for JS Docker build
Copilot Aug 12, 2026
312af37
Merge remote branch history after rebase
Copilot Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,18 @@
# syntax=docker/dockerfile:1
FROM node:24-bookworm-slim AS node-build
WORKDIR /App

# Build javascript library. The npm cache mount speeds up repeated local builds.
COPY . ./
RUN --mount=type=cache,id=try-npm,target=/root/.npm \
/App/build-js.sh

FROM mcr.microsoft.com/dotnet/sdk:10.0-azurelinux3.0 AS build-env
WORKDIR /App

# Make sure we run bash
CMD ["bash"]

# Install all required build tools in a single layer (rarely changes — stays cached)
# Use nodejs24 for Node 24.x (required for ESM-compatible dependencies).
RUN --mount=type=cache,id=try-tdnf,target=/var/cache/tdnf,sharing=locked \
tdnf install -y gawk nodejs24 nodejs24-npm

# Copy only the files needed to restore dependencies.
# These layers are cached until a manifest file changes, so routine source edits
# don't re-run the expensive restore steps below.
Expand Down Expand Up @@ -38,9 +41,9 @@ RUN --mount=type=cache,id=try-nuget,target=/root/.nuget/packages \
# Copy all remaining source (changes frequently — only layers below rebuild on edits)
COPY . ./

# Build javascript library. The npm cache mount speeds up repeated local builds.
RUN --mount=type=cache,id=try-npm,target=/root/.npm \
/App/build-js.sh
# Bring built JS/CSS artifacts from the Node build stage.
COPY --from=node-build /App/src/Microsoft.TryDotNet/wwwroot/api /App/src/Microsoft.TryDotNet/wwwroot/api
COPY --from=node-build /App/src/Microsoft.TryDotNet/wwwroot/css /App/src/Microsoft.TryDotNet/wwwroot/css

# Publish only what we deploy
RUN --mount=type=cache,id=try-nuget,target=/root/.nuget/packages \
Expand Down