refactor: scatter-gather-autograd-refactor#164
Open
kilinchange wants to merge 2 commits into
Open
Conversation
kilinchange
force-pushed
the
refactor/scatter-gather-autograd-refactor
branch
from
a91cb12 to
1135a56
Compare
kilinchange
changed the title
… via namespaces, and reorganize functions in misc files
kilinchange
force-pushed
the
refactor/scatter-gather-autograd-refactor
branch
from
1135a56 to
d85350f
Compare
Collaborator
Author
|
精度测试： |
Chamberlain0w0
requested changes
Jun 3, 2026
Contributor
Chamberlain0w0
left a comment
Chamberlain0w0
left a comment
There was a problem hiding this comment.
LGTM，仅有一个 check 的部分没和其他部分逻辑对齐
| const int64_t topk = values->Dims().back(); | ||
| const int64_t num_experts = output_dims.back(); | ||
| CHECK_GT(num_experts, 0); | ||
| const int64_t rows = values->NumElements() / topk; |
Contributor
There was a problem hiding this comment.
对比 CPU 版实现，缺少 CHECK_EQ(output_numel, static_cast<size_t>(rows * num_experts)); 的校验，否则 kernel 中 output[row * num_experts + expert_idx] = values[idx]; 可能越界写
Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#153 前置 pr，主要内容：