refactor InfiniOps cpu runtime through InfiniRT#644
Draft
spike-zhu wants to merge 1 commit into
Draft
Conversation
voltjia
requested changes
Jun 5, 2026
| ) | ||
| params.update(_find_optional_tensor_params(op_name)) | ||
| params.update(_find_vector_tensor_params(op_name)) | ||
| return params |
Collaborator
There was a problem hiding this comment.
需要注意核对 CONTRIBUTING.md，比如这里 return 上面应该空一行。
| option(GENERATE_PYTHON_BINDINGS "Generate Python bindings" OFF) | ||
| option(USE_EXISTING_GENERATED_WRAPPERS | ||
| "Build from existing generated wrapper sources instead of regenerating them" OFF) | ||
| option(INFINIOPS_MINIMAL_ADD_BINDINGS |
Collaborator
There was a problem hiding this comment.
这个是用来干啥的？如果只是开发时测试用途的话，这里就先不要了。
| option(GENERATE_OPERATOR_CALL_INSTANTIATIONS | ||
| "Generate explicit operator call instantiations" ON) | ||
| option(GENERATE_PYTHON_BINDINGS "Generate Python bindings" OFF) | ||
| option(USE_EXISTING_GENERATED_WRAPPERS |
Collaborator
There was a problem hiding this comment.
这个功能的确是需要的，但是不应该跟着这个 PR 提，应该单独拆分出一个 PR。而且这个看上去有点一刀切，应该做成那种通过识别 hash 等方式来决定是否重新生成，然后自动开启。
Collaborator
There was a problem hiding this comment.
确认一下这个文件里的三个类是否都真的会被用到，也许有的只是 InfiniRT 内部会用到，但是 InfiniOps 用不到，如果存在这种情况的话，那这个文件里就可以去掉对应的那几行。
Comment on lines
+10
to
+15
| using infini::rt::BFloat16; | ||
| using infini::rt::DataType; | ||
| using infini::rt::Float16; | ||
| using infini::rt::kDataTypeToDesc; | ||
| using infini::rt::kDataTypeToSize; | ||
| using infini::rt::kStringToDataType; |
Collaborator
There was a problem hiding this comment.
这个地方的顺序有点奇怪，按理说应该按照替换钱的顺序排序，然后适当插入空行，可以看看是不是改成如下形式：
using infini::rt::DataType;
using infini::rt::Float16;
using infini::rt::BFloat16;
using infini::rt::kDataTypeToSize;
using infini::rt::kDataTypeToDesc;
using infini::rt::kStringToDataType;
| list(FILTER BASE_SRCS EXCLUDE REGEX ".*tensor\\.cc$") | ||
| target_sources(infiniops PRIVATE ${BASE_SRCS}) | ||
|
|
||
| set(INFINIOPS_EMPTY_SOURCE "${CMAKE_CURRENT_BINARY_DIR}/infiniops_empty.cc") |
Collaborator
There was a problem hiding this comment.
这个 infiniops_empty.cc 是干啥的？
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Closes #
Type of Change
feat— new feature / new operator / new platformfix— bug fixperf— performance improvement (no behavioral change)refactor— code restructuring without behavior changetest— adding or fixing tests onlydocs— documentation onlybuild/ci— build system or CI configurationchore— tooling, formatting, or other non-code changes!in the Conventional Commits prefix or aBREAKING CHANGE:footer)Platforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Test Results on Supported Platforms
pytestResultFull `pytest` output (optional)
Benchmark / Performance Impact
Notes for Reviewers
Checklist
Title, Branch, and Commits
feat(nvidia): …,fix(cuda/gemm): …).<type>/xxx-yyyy-zzzzwhere<type>matches the PR title's Conventional Commits type and words are joined with hyphens (seeCONTRIBUTING.md§Branches).CONTRIBUTING.md§Pull Requests).master— the branch is rebased cleanly on top of the currentmaster.fixup!/squash!/wipcommits remain.Scope and Design
CONTRIBUTING.md§Code/General).printf/std::cout/print(...)left behind, orTODOwithout an owner and issue link.General Code Hygiene (applies to all languages)
CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General).the `seqlens_k` tensor) (CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General; §Python).C++ Specific (if C++ files changed)
clang-format(version 21, per.github/workflows/clang-format.yml) has been run against all modified.h,.cc,.cuh, and.mlufiles; the diff is clean.clang-tidyconcerns (per.clang-tidy) have been reviewed — no new warnings beyond the existing baseline.CONTRIBUTING.md§C++).assertwith messages that include at least__FILE__,__LINE__, and__func__(CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).kernel/kernel_v2/ …; well-known algorithms use the algorithm name; library-based implementations use the library name (CONTRIBUTING.md§C++)..h, kernel follows platform conventions (e.g..cuh+.cu) even when non-templated (CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).src/base/<op>.h(inheritingOperator<Op>) with platform implementations undersrc/<category>/<platform>/inheriting the base (CONTRIBUTING.md§Adding an Operator).new/delete; RAII / smart pointers / existing allocators are used.Python Specific (if Python files changed)
ruff checkpasses cleanly on CI (see.github/workflows/ruff.yml).ruff format --checkpasses cleanly — if not, runruff formatand commit the result.CONTRIBUTING.md§Python).pytest.skipmessages without terminal period) are honored where applicable (CONTRIBUTING.md§Python).CONTRIBUTING.md§Python).if,for, and similar control-flow statements (CONTRIBUTING.md§Python).return, except when it directly follows a control-flow statement (CONTRIBUTING.md§Python).CONTRIBUTING.md§Python).Testing
pytestwas run locally on every supported platform that this PR can affect, and the results are recorded in the "Test Results" table above (CONTRIBUTING.md§Pull Requests).tests/followingtests/test_add.py/tests/test_gemm.pypatterns (CONTRIBUTING.md§Adding an Operator).pytest.mark.parametrizecorrectly: dependent parameters share one decorator (e.g.@pytest.mark.parametrize("dtype, rtol, atol", …)), independent parameters use separate decorators ordered by parameter declaration.pytest.mark.auto_act_and_assertis used and the test returns aPayloadwhosefuncandrefshare the same calling convention.dtype/deviceparameterization is relied on, or overridden with an explicitpytest.mark.parametrizewhen necessary.pytest -n 1.masterand passes with this PR.Build, CI, and Tooling
pip install .[dev]on at least one affected platform.compile_commands.jsonstill regenerates (CMake optionCMAKE_EXPORT_COMPILE_COMMANDS=ONinpyproject.toml— required by thecode-lintskill andclang-tidy -p).CMakeLists.txtunderif(AUTO_DETECT_DEVICES)and toif(AUTO_DETECT_BACKENDS)if applicable.CMakeLists.txtis not broken.clang-format.yml,ruff.yml) are green locally (or expected to be green on CI).pyproject.toml's[project.optional-dependencies](or justified in the PR description).Documentation
README.md,CONTRIBUTING.md, or inline docs updated when behavior, build flags, or developer workflow changed.CONTRIBUTING.md§Some Code Explanations).!orBREAKING CHANGE:footer.Security and Safety