build: read plugin CMake entry from manifest#642
Draft
voltjia wants to merge 1 commit into
Draft
Conversation
678b5df to
d132b5a
Compare
e7ed421 to
9129246
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make CMake respect the
cmake_entrydeclared by each plugin manifest instead of assuming the entry file is alwaysplugin.cmake.This PR is stacked on #641 (
ci/path-aware-shadow).Changes
plugin.jsonmanifest across configured plugin roots.cmake_entryfield and include that CMake entry.cmake_entryvalues at CMake configure time.plugin.cmake.Validation
.venv/bin/python -m pytest -s -q tests/test_plugin_registry.py tests/test_plugin_test_matrix.py tests/test_generate_wrappers_plugins.py.venv/bin/ruff check scripts/infini_ops_plugin_registry.py scripts/infini_ops_plugin_test_matrix.py scripts/generate_wrappers.py tests/test_plugin_registry.py tests/test_plugin_test_matrix.py tests/test_generate_wrappers_plugins.py.venv/bin/python -m py_compile scripts/infini_ops_plugin_registry.py scripts/infini_ops_plugin_test_matrix.py scripts/generate_wrappers.pygit diff --checkcmake_entryconfigure/build smokeFull-platform validation
Full stack validation was run on the top branch
build/external-plugin-source-pathsat pre-style-rebase commit907eff70; see #643 validation comment: #643 (comment). The later rebase only updates PR metadata and diagnostic wording forCONTRIBUTING.mdcompliance.1 failed, 3687 passed, 4404 skippeddue to CUDA OOM intests/test_torch_ops.py::test_op[..., svd]on the PyTorch reference path.3183 passed, 3400 skipped.2689 passed, 3894 skipped.2949 passed, 3643 skipped.1781 passed, 4694 skipped.3359 passed, 3233 skipped, but the container exited with code137; treat as not fully green by the quality gate.