Add build-time plugin contract#633
Draft
voltjia wants to merge 1 commit into
Draft
Conversation
voltjia
force-pushed
the
feat/build-plugin-contract
branch
from
850951c to
034bc25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduce a build-time plugin contract for InfiniOps platform backends while keeping the produced
libinfiniopsand Pythonopsmodule unchanged.This PR adds:
infini_ops_register_plugin,infini_ops_register_device) andINFINI_OPS_PLUGINSselectionWITH_<PLATFORM>options to the new plugin enable pathcuda-commonis modeled as a shared plugin and is pulled in by CUDA-like device plugins rather than exposed as a user device.Validation
.venv/bin/python -m py_compile scripts/infini_ops_plugin_registry.py scripts/generate_wrappers.py.venv/bin/python -m pytest -s -q tests/test_plugin_registry.py tests/test_generate_wrappers_plugins.py.venv/bin/ruff check scripts/infini_ops_plugin_registry.py scripts/generate_wrappers.py tests/test_plugin_registry.py tests/test_generate_wrappers_plugins.py/home/voltjia/.cache/uv/archive-v0/xuDH-Kne6u5S9ov7/bin/cmake -S . -B build/plugin-cpu-rename-smoke -DINFINI_OPS_PLUGINS=cpu -DGENERATE_PYTHON_BINDINGS=OFF -DGENERATE_OPERATOR_CALL_INSTANTIATIONS=OFF/home/voltjia/.cache/uv/archive-v0/xuDH-Kne6u5S9ov7/bin/cmake --build build/plugin-cpu-rename-smoke --target infiniops --parallel 2/home/voltjia/.cache/uv/archive-v0/xuDH-Kne6u5S9ov7/bin/cmake -S . -B build/plugin-legacy-cpu-rename-smoke -DWITH_CPU=ON -DGENERATE_PYTHON_BINDINGS=OFF -DGENERATE_OPERATOR_CALL_INSTANTIATIONS=OFFHardware backend builds/tests were not run locally.