issue/1124: minicpm-sala model #1125
Open
Ceng23333 wants to merge 10 commits into
Open
Conversation
Ceng23333
force-pushed
the
minicpm_sala_patches
branch
from
c99c78a to
fb8eba4
Compare
wooway777
requested changes
Apr 9, 2026
|
|
||
| template <> | ||
| struct Convert<__half> { | ||
| __device__ static float to_f32(__half x) { return f16_to_f32(x); } |
Collaborator
There was a problem hiding this comment.
感觉仓库里已经有不少转换函数了，好多kernel里都自己定义了转换函数···不确定应不应该什么时候整理一下
PanZezhong1725
requested changes
Apr 9, 2026
Ceng23333
force-pushed
the
minicpm_sala_patches
branch
from
0435097 to
b2c5e1b
Compare
Signed-off-by: Ceng23333 <441651826@qq.com>
Signed-off-by: Ceng23333 <441651826@qq.com>
Signed-off-by: Ceng23333 <441651826@qq.com>
Signed-off-by: Ceng23333 <441651826@qq.com>
Signed-off-by: Ceng23333 <441651826@qq.com>
Signed-off-by: Ceng23333 <441651826@qq.com>
Signed-off-by: Ceng23333 <441651826@qq.com>
Ceng23333
force-pushed
the
minicpm_sala_patches
branch
from
947d42a to
44911ce
Compare
Signed-off-by: Ceng23333 <441651826@qq.com>
wooway777
requested changes
Jun 3, 2026
Collaborator
wooway777
left a comment
wooway777
left a comment
There was a problem hiding this comment.
后面还很多没看完，后面有时间再看吧。其他几个reviewer能不能也发发力
Collaborator
There was a problem hiding this comment.
是不是应该像隔壁一样，以adaptor为文件名？
| */ | ||
| #pragma once | ||
|
|
||
| #include "infinicore/adaptor/infllmv2_api.hpp" |
Collaborator
There was a problem hiding this comment.
要不就直接想flash attention一样，在.cc里直接引用infllmv2_adaptor.hpp就得了？跳转这一下是有其他设计意图么？
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1124