Repository navigation
update: run post-upgrade setup from the installed CLI, prune after (0.1.87) - #132
Merged
sh1pt-actions-fleet[bot] merged 1 commit intoNov 2, 2026
Merged
Conversation
….1.87) During the 0.1.86 rollout bonita's hourly `infernet update` ran from the npm-global copy. The installer (correctly) kept the node on git, then update removed the npm copy and ran setup in-process from that removed copy, which rewrote infernet.service to point at it: the daemon crash-looped for ~70 s until the unit was rewritten by hand. Now update hands setup to the CLI the wrapper runs when that is not this process, and removes stray copies only after setup. CLI_DIR is a real path so the comparison holds through symlinked prefixes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
ThreatCrush Security Scan40 finding(s) HIGH/CRITICAL: 6 | MEDIUM: 14 | LOW: 20
Snippets are redacted; ThreatCrush never prints matched credential material. |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| for (const k of ['port', 'address', 'no-advertise']) { | ||
| if (args.has(k)) setupArgs.set(k, args.get(k) ?? true); | ||
| } | ||
| code = await setup(setupArgs, ctx); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fourth fix from the live rollout on bonita. This one took the daemon down for about 70 s.
What happened. At 15:19Z, bonita's hourly
infernet updateran from the npm-global copy (0.1.84; the 14:52 npm-path install had repointed the wrapper at it).updatethen removed the npm copy, before setup.infernet.servicetonode <npm copy>/index.jsand failed withCannot find module.~/.local/bin/infernet service install. It came back on 0.1.86 at 15:20:25Z and served jobs again right away.Fix.
updatehands post-upgrade setup to that installed CLI (<wrapper> setup --yes --confirm --skip-pull).CLI_DIRis now a realpath, so the comparison holds through symlinked prefixes (mise's24->24.18.1).A test covers
setupRunsFrom.pnpm vitest run: 967 passed.apps/cli/package.json-> 0.1.87.🤖 Generated with Claude Code