Open
Conversation
kyngs
requested changes
Apr 22, 2026
Member
kyngs
left a comment
kyngs
left a comment
There was a problem hiding this comment.
Great work! Please check my comments, mainly I think the entire CountingOutputStream may be unnecessary? (See the commend in SlimeSerializer for further details)
…edCompound to SlimeWorldDeserializerHelper
Member
Author
|
@kyngs I think I fixed everything |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the deserialization and serialization to reduce heap allocation.
In extreme cases, up to 80% improvement on memory usage is possible.
Loading performance is roughly the same, saving performance has yet to be tested.