Skip to content

Audit SwiftUI state privacy for lazy @State #6

Closed

Description

@andywkff

Audit SimpleChart against Point-Free's SwiftUI @State macro guidance: https://x.com/pointfreeco/status/2093052971890229285

Acceptance criteria:

  • Genuine mutable @State storage is private.
  • Immutable parent inputs are not modeled as @State.
  • Stable and Xcode 27 beta builds/tests pass.
  • No unrelated files are changed.

Activity

  1. added theissue type on Aug 28, 2026
  2. andywkff commented on Aug 28, 2026

    @andywkff
    ContributorAuthor

    Audit complete: 26 @State declarations were found. The 23 non-private declarations were immutable legacy config, data, and size inputs, so they have been changed to private let. The three genuine mutable state properties were already @State private. Static scan now finds no non-private @State declarations.

  3. andywkff commented on Aug 28, 2026

    @andywkff
    ContributorAuthor

    Verification complete:

    • Stable Xcode warnings-as-errors library build passed.
    • Xcode 27 beta warnings-as-errors library build passed.
    • Stable Xcode full suite: 78 tests passed, 0 failures.
    • Xcode 27 beta full suite: 78 tests passed, 0 failures.
    • Static scan finds exactly three remaining @State declarations, all private.
    • git diff --check passes.
  4. andywkff commented on Sep 1, 2026

    @andywkff
    ContributorAuthor

    Published in 12508bebeae88d5e9a89ff0dfe46b367de10b1d2 (Privatize SwiftUI state storage). The feature branch and main were fast-forwarded and pushed; local and remote refs all converge at this commit, with both worktrees clean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions