Allow for HF org with different name from code platform org#110
Open
egrace479 wants to merge 11 commits into
Open
Allow for HF org with different name from code platform org#110egrace479 wants to merge 11 commits into
egrace479 wants to merge 11 commits into
Conversation
egrace479
added
enhancement
egrace479
force-pushed
the
feat/mismatched-hf
branch
from
324f8b8 to
093bd05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I was setting up a test config for a Codeberg organization, the challenge of a Hugging Face org having a different name than the code platform org became glaringly obvious. This PR fixes that by adding a
HF_ORGANIZATION_NAMEparameter. It also adds a config validation check on a dev run and checks that the organization name variables are lowercase. Example console output with uppercase HF org name and unsupported platform passed:The config path is defined from a variable in the message.
As discussed in #93, adding a different data or model platform would be a much bigger project requiring community motivated use-case(s), and having HF optional would be similar. Thus, this is a simple parameter addition; the app also requires it to be filled.