Skip to content

Backbot: Post one summary comment and include original PR description in backports - #11164

Merged
yhabteab merged 3 commits into
masterfrom
backbot-fix
Nov 9, 2026
Merged

yhabteab merged 3 commits into
masterfrom
backbot-fix

Conversation

@yhabteab

@yhabteab yhabteab commented Nov 9, 2026 •

Copy link
Copy Markdown
Member

Set comment_style: summary so the action leaves one comment that links all backport PRs, instead of one comment per target branch as used to. Lastly, add ${pull_description} to the backport PR body to include the original PR, which will be relevant for Icinga/icinga-notifications#606.

Also, dropped the ineffective sha input from the checkout step for that action.

@yhabteab yhabteab added this to the 2.17.0 milestone Nov 9, 2026
@yhabteab
yhabteab requested a review from julianbrost November 9, 2026 08:44
@yhabteab yhabteab added the backport-to-support/2.16 PRs with this label will automatically be backported to the v2.16 support branch. label Nov 9, 2026
@cla-bot cla-bot Bot added the cla/signed label Nov 9, 2026
Comment thread .github/workflows/backbot.yml Resolved
Set `comment_style: summary` so the action leaves one comment that
links all backport PRs, instead of one comment per target branch.
Add `${pull_description}` to the backport PR body so reviewers see
the original context without having to open the source PR.
`sha` isn't a valid `actions/checkout` input (it's `ref`), so the
attempt to pin the PR head commit was silently ignored and the job has
always checked out the base branch. That's also the right thing to do:
the backport action fetches the PR commits and cherry-picks them onto
the support branches itself, so it doesn't need the PR head checked out.
@yhabteab yhabteab added github_actions Pull requests that update GitHub Actions code and removed backport-to-support/2.16 PRs with this label will automatically be backported to the v2.16 support branch. labels Nov 9, 2026
@yhabteab
yhabteab merged commit 9352d15 into master Nov 9, 2026
45 of 46 checks passed
@yhabteab
yhabteab deleted the backbot-fix branch November 9, 2026 15:21
@backbot-ci

backbot-ci Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Backport-action found no target branches to backport this pull request to in workflow run 42643771284.

This can happen when the pull request has no labels matching label_pattern, or when no target_branches were configured.

To avoid unnecessary action runs, update your workflow so this action only runs for PRs that should be backported, such as PRs with a matching backport label or runs with explicit target_branches.

@julianbrost

Copy link
Copy Markdown
Member

Was this some kind of race condition between you removing the backport label and merging this PR? 🤨

Otherwise I don't know how this change is supposed to cause that.

@yhabteab

yhabteab commented Nov 9, 2026

Copy link
Copy Markdown
Member Author

I think, it's a new feature of that action :). I'll look if we can disable that somehow.

@yhabteab

yhabteab commented Nov 9, 2026

Copy link
Copy Markdown
Member Author

It's due to comment_style: summary. It posts the above comment even when it didn't find any target branches to back port the PRs to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla/signed github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants