Skip to content

go: Common Go Check - #38

Merged
oxzi merged 1 commit into
mainfrom
go-common
Nov 10, 2026
Merged

oxzi merged 1 commit into
mainfrom
go-common

Conversation

@oxzi

@oxzi oxzi commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

Add a generic GitHub Actions Workflow to build and test all our Go code. It is based the IGL, Icinga DB, Icinga Notifications, and Icinga for K8s.


At the moment, this will just unify our Go actions. In a later step, a SBOM attestation will be added based on the Go built, including the compiler version and so on. This, however, requires a common GitHub Actions workflow.

The four downstream PRs successfully went through. However, some need a change in the required actions, which changed due to the unification.

@yhabteab

Copy link
Copy Markdown
Member

What's the reason for putting each of the individual steps into their own runners though? Shouldn't a single runner be enough for all of them?

@oxzi

oxzi commented Nov 10, 2026

Copy link
Copy Markdown
Member Author

What's the reason for putting each of the individual steps into their own runners though? Shouldn't a single runner be enough for all of them?

Following Icinga DB and Icinga for K8s.

As stated in the OP, this squashes four diverging approaches into one.

@yhabteab

Copy link
Copy Markdown
Member

As stated in the OP, this squashes four diverging approaches into one.

I did read that but you're squashing them into the wrong approach IMHO. All those steps shouldn't need their own runners each. Yes, they're not long running but still I would just add them as separate steps instead like how IGL and Icinga Notifications already do.

Add a generic GitHub Actions Workflow to build and test all our Go
code. It is based the IGL, Icinga DB, Icinga Notifications, and Icinga
for K8s.
@oxzi

oxzi commented Nov 10, 2026

Copy link
Copy Markdown
Member Author

Changed it and triggered another CI run for all consumers.

I did read that but you're squashing them into the wrong approach IMHO.

Please feel free to tell me directly if you think another approach would be better. This Socratic questioning just introduces a round-trip.

@yhabteab

yhabteab commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

Please feel free to tell me directly if you think another approach would be better. This Socratic questioning just introduces a round-trip.

Hu, did I say something wrong? I didn't check at first what Icinga DB and Kubernetes used to run those steps, so I asked a simple question to get if there's a reason for this that I'm not aware of. Is this socratic questioning? Also, I already commented what I think, is better, directly with my previous comment.

@oxzi

oxzi commented Nov 10, 2026

Copy link
Copy Markdown
Member Author

Please feel free to tell me directly if you think another approach would be better. This Socratic questioning just introduces a round-trip.

Hu, did I say something wrong? I didn't check at first what Icinga DB and Kubernetes used to run those steps, so I asked a simple question to get if there's a reason for this that I'm not aware of. Is this socractic questioning? Also, I already commented what I think, is better, directly with my previous comment.

Sorry, I didn't mean to sound rude. I just wanted to refer to your first (and rightful) comment, where you asked why I did this.

@oxzi
oxzi merged commit 08d00bb into main Nov 10, 2026
13 checks passed
@oxzi
oxzi deleted the go-common branch November 10, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla/signed CLA is signed by all contributors of a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants