Permute the contraction result directly into the destination in unmatricizeadd!#182
Merged
Conversation
…ricizeadd! unmatricizeadd! materialized a permuted copy of the matricized result and then added it into the destination. It now permutes that result straight into the destination in a single accumulating pass via bipermutedimsopadd!, mirroring unmatricize!, removing one output-sized allocation per contraction.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #182 +/- ##
==========================================
+ Coverage 78.59% 78.69% +0.09%
==========================================
Files 20 20
Lines 654 657 +3
==========================================
+ Hits 514 517 +3
Misses 140 140
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unmatricizeadd!materialized a permuted copy of the matricized contraction result and then added it into the destination. It now permutes that result straight into the destination in a single accumulating pass (viabipermutedimsopadd!), mirroringunmatricize!. This removes one output-sized allocation per contraction: a contraction whose output needs a non-trivial permutation drops from 5× to 4× the output size in temporaries, on par with ITensors and TensorOperations, with no change in results.