Get Guestbook list API: add param to return inherited guestbooks#12326
Open
stevenwinship wants to merge 1 commit intodevelopfrom
Open
Get Guestbook list API: add param to return inherited guestbooks#12326stevenwinship wants to merge 1 commit intodevelopfrom
stevenwinship wants to merge 1 commit intodevelopfrom
Conversation
github-actions
bot
added
FY26 Sprint 21
|
coverage: 24.872% (-0.002%) from 24.874% — 12323-get-inherited-guestbooks-list-api into develop |
This comment has been minimized.
This comment has been minimized.
stevenwinship
moved this from In Progress 💻
to Ready for Review ⏩
in IQSS Dataverse Project
stevenwinship
force-pushed
the
12323-get-inherited-guestbooks-list-api
branch
from
ea17f11 to
5eebb76
Compare
This comment has been minimized.
This comment has been minimized.
stevenwinship
force-pushed
the
12323-get-inherited-guestbooks-list-api
branch
from
5eebb76 to
e0b6846
Compare
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Since a dataset can use a guestbook assigned to a parent collection the list api must have a way to include these guestbooks. Getting the list for a given Dataverse should be used for managing the Dataverse. The list including parent Guestbooks should be used for selecting the Guestbook to assign to a Dataset.
Which issue(s) this PR closes:#12323
Special notes for your reviewer: 'EditGuestbook' permissions were removed since this API is read only
Suggestions on how to test this: Create a hierarchy of Dataverse Collections with Guestbooks. Get the list for a given Dataverse as well as the list for the hierarchy.
Does this PR introduce a user interface change? If mockups are available, please link/include them here: N/A
Is there a release notes update needed for this change?: Included
Additional documentation: