Repository navigation
Preserve microseconds in DateTime and Duration - #341
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #341 +/- ##
==========================================
+ Coverage 93.66% 93.68% +0.02%
==========================================
Files 66 66
Lines 2668 2678 +10
==========================================
+ Hits 2499 2509 +10
Misses 169 169 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
@Rexios80 That was quick! A few range problems with implementation:
I would recommend something like: double _encodeMillis(int micros) {
final whole = micros ~/ 1000;
return whole + (micros - whole * 1000) / 1000;
}
int _decodeMicros(double millis) {
final whole = millis.truncate();
return whole * 1000 + ((millis - whole) * 1000).round();
}The mock tests only use |
Member
Author
|
Yeah I'm still working on this. Thanks for the help. |
Member
Author
|
@LahaLuhem Are you happy with this? |
Contributor
LGTM. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DateTimeandDurationadapters now store microseconds as a fractional millisecond double, using the approach proposed by @LahaLuhem in the issuehive_ceto 2.21.0Test plan
dart analyzedart test -p vmdart test -p chrome test/tests/adapters