Skip to content

chore: remove extend dependency#322

Open
gameroman wants to merge 5 commits intoIBM:mainfrom
gameroman:replace-extend
Open

chore: remove extend dependency#322
gameroman wants to merge 5 commits intoIBM:mainfrom
gameroman:replace-extend

Conversation

@gameroman
Copy link
Copy Markdown

Checklist
  • npm test passes (tip: npm run lint-fix can correct most style issues)
  • tests are included
  • documentation is changed or added

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 3, 2026

CLA assistant check
All committers have signed the CLA.

@gameroman gameroman marked this pull request as ready for review April 3, 2026 13:15
@pyrooka
Copy link
Copy Markdown
Member

pyrooka commented Apr 10, 2026

Hey @gameroman, thanks for the contribution. We'll try to look into the PR soon, but I'd like to ask two things in the meantime:

  1. Sign off all your commits in the branch, otherwise the DCO check will keep failing
  2. Since the purpose of this PR is to remove the extend dependency from the project, it should be also removed from the package.json - along with package-lock.json -, right?

Comment thread lib/cookie-support.ts Outdated
Comment thread lib/request-wrapper.ts Outdated
@diatrcz
Copy link
Copy Markdown
Contributor

diatrcz commented Apr 14, 2026

Hi @gameroman, thank you for the contribution. Additionally to the change requests:

  1. As stated above, please sign your commits so DCO stops failing and remove extend from package.json and package-lock.json.
  2. Please keep the branch up to date with the main branch.

@gameroman
Copy link
Copy Markdown
Author

Thank you for the review, I’ll fix everything when I get back👍

@gameroman gameroman marked this pull request as draft April 14, 2026 17:42
Signed-off-by: Roman <dev@rman.dev>
@gameroman gameroman marked this pull request as ready for review April 28, 2026 07:48
@gameroman gameroman requested a review from diatrcz April 28, 2026 07:48
Comment thread lib/request-wrapper.ts Outdated
Signed-off-by: Roman <dev@rman.dev>
@gameroman gameroman requested a review from diatrcz April 28, 2026 16:31
Copy link
Copy Markdown
Contributor

@diatrcz diatrcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. However, the dependency is still listed in devDependencies. To complete the removal of the extend dependency, it should also be removed from there, even if this requires additional updates to the test codebase.

Comment thread package.json Outdated
@gameroman gameroman marked this pull request as draft May 5, 2026 11:54
@gameroman gameroman marked this pull request as ready for review May 5, 2026 17:36
@gameroman gameroman requested a review from diatrcz May 5, 2026 17:48
@gameroman gameroman marked this pull request as draft May 6, 2026 10:49
@gameroman gameroman marked this pull request as ready for review May 6, 2026 15:50
@gameroman
Copy link
Copy Markdown
Author

Weird, not sure why npm ci is failing. I've ran it locally and the lockfile is up-to-date

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants