Added upload (and debug) to whitelisted URLs#4858
Merged
Merged
Conversation
Contributor
Author
|
this test is proving a little annoying to fix |
wes-otf
force-pushed
the
fix/upload-failures-with-2FA
branch
from
e513bdc to
f50d800
Compare
Contributor
Author
|
This works but I'm questioning how effective those tests actually are in general, from what I'm seeing a 200 is normally still returned but the HTML is the |
frjo
approved these changes
May 26, 2026
frjo
added
Type: Bug
Member
|
@wes-otf Nice work on finding this bug, a real edge case. |
Contributor
Author
|
@frjo it actually kept coming up for OTF and was driving us nuts, thankfully @Techslammer correlated 2FA to the error today |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4857, adds the upload URL prefix to whitelisted URLs to allow for uploading of files to complete a submission without needing to do 2FA. (also added
/__debug__/as the toolbars were failing to load)Test Steps
ENFORCE_TWO_FACTOR=TrueandFORCE_LOGIN_FOR_APPLICATION=True, ensure uploading a file as a user without 2FA enabled works as expected.