ci(release): give the parity job room for its cache save - #5885
Conversation
The v0.9.12 tag push ran release.yml's parity job to a clean pass on every step, then the runner cancelled it at the 20-minute job timeout during rust-cache's post-run save, which skipped artifacts, the GitHub Release, npm, Docker, and Homebrew. Raise the bound to 45 minutes; the gate itself is unchanged (release-workflows contract test passes). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Bs5x11yXAg3sJ4giZf4krF
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_ade4355f-5867-4825-8802-59b71203b242) |
|
Claude Code is working… I'll analyze this and get back to you. |
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Bs5x11yXAg3sJ4giZf4krF
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_2b5ed3cd-1d6b-41d0-b039-fe872a14910f) |
|
Claude finished @Hmbown's task in 34s —— View job Review: parity job timeout bump (20 → 45 min)
Summary: Small, well-scoped workflow-only change. Findings:
Note: I was not able to execute Nit (optional, not blocking): 45 minutes is a generous margin purely to survive a cache-save tail after a job that otherwise finishes in well under 20 minutes. If this recurs, it may be worth separately investigating why |
There was a problem hiding this comment.
🟢 Approval recommended
The change is a narrowly-scoped workflow timeout adjustment with matching contract-test updates, and the YAML structure/indentation remains valid.
Pull request overview
Increases the GitHub Actions release workflow’s parity job timeout so successful runs aren’t cancelled during the rust-cache post-run cache save, which previously prevented downstream release jobs from running.
Changes:
- Raised
.github/workflows/release.ymlparityjobtimeout-minutesfrom 20 → 45. - Updated the release workflow contract test to assert the new timeout and documented the v0.9.12 failure mode in comments.
File summaries
| File | Description |
|---|---|
.github/workflows/release.yml |
Extends parity job timeout to avoid cancellation during cache save. |
.github/scripts/release-workflows.test.js |
Updates workflow contract assertion for the new parity timeout and adds context comments. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5b94d1d187
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| parity: | ||
| timeout-minutes: 20 | ||
| timeout-minutes: 45 |
There was a problem hiding this comment.
The checked ci.yml Tests job always runs .github/scripts/release-workflows.test.js, whose line 668 still requires the parity timeout to equal 20. With this value changed to 45, the test deterministically aborts with 45 !== 20, making every push or PR that runs the release-helper contracts go red; update the contract assertion alongside the workflow.
AGENTS.md reference: AGENTS.md:L112-L117
Useful? React with 👍 / 👎.
![codewhale-agent[bot]](https://avatars.githubusercontent.com/u/101357273?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codewhale review
PR raises the release workflow parity job timeout from 20 to 45 minutes so rust-cache's post-run cache save can finish after the parity steps complete. The release-workflows contract test assertion is updated to match, with an explanatory comment.
Assessment
Workflow-only change is low risk and correctly synchronizes the release workflow with its contract test. No correctness or test coverage concerns.
Advisory review by Codewhale (codewhale review --pr 5885 --post, head 2aa6bc952d31cd4416922a668478f7f735880c3f). Line-specific findings are also posted as inline review comments; mechanical fixes arrive as committable suggestions you can apply from the Files tab. CODEOWNERS approval still governs merge.
The v0.9.12 tag push ran release.yml parity to a clean pass on every step and was then cancelled at the 20-minute job timeout during the rust-cache post-run save, skipping artifacts/release/npm/docker/homebrew. This raises the parity bound to 45 minutes. Workflow-only change; release-workflows contract test passes.
No-Issue: CI hardening found during the v0.9.12 release.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Bs5x11yXAg3sJ4giZf4krF
Note
Low Risk
Workflow timeout-only change with no application or release-logic edits; it reduces false timeouts on tag releases.
Overview
Raises the release workflow
parityjob limit from 20 to 45 minutes so the job can finishrust-cache’s post-run cache save after the Rust gates complete.The contract test in
release-workflows.test.jsnow expects 45 minutes, with a note that v0.9.12 hit the old cap during cache save even though every parity step had already passed—downstream artifacts, release, npm, docker, and homebrew never ran.Reviewed by Cursor Bugbot for commit 2aa6bc9. Bugbot is set up for automated code reviews on this repo. Configure here.