fix(web): drop unused Discord badge class - #5289
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Claude finished @Hmbown's task in 3m 40s —— View job Review of PR #5289
This PR is entirely in Bug: duplicated "Codewhale" in the OG/social card
But two call sites still prepend
This renders as "Codewhale — Codewhale dives into the deep so you don't have to — any model, on your machine." — and the actual generated PNG (
Fix: either drop "Codewhale" back out of Minor / non-blocking
Verified good
I wasn't able to install dependencies in this environment (no |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b9f8c4df98
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| /** The one-line product identity, used as the default OG image alt text. */ | ||
| export const IDENTITY_PHRASE = | ||
| "Dive into the deep so you don't have to — any model, local-first."; | ||
| "Codewhale dives into the deep so you don't have to — any model, on your machine."; |
There was a problem hiding this comment.
Remove the duplicated brand from OG image alt text
Because both OG_IMAGE.alt here and app/opengraph-image.tsx prepend SITE_NAME, adding “Codewhale” to IDENTITY_PHRASE makes every social-card alternative read Codewhale — Codewhale dives into the deep…. Screen-reader users encounter this duplicated label on every localized page; either keep the identity phrase brand-free or stop prepending the site name.
Useful? React with 👍 / 👎.
The Discord nav button already has its complete styling through site-discord-link. Remove the stale paper-discord-badge class, which has no CSS definition.\n\nNo-Issue: tiny cleanup found while rebuilding #5289 on current main.\n\nAgent-assisted; verified against the current web styles.
b9f8c4d to
fa6eadc
Compare
|
Claude finished @Hmbown's task in 33s —— View job Review of PR #5289
SummaryClean, minimal fix. The diff removes - className="site-discord-link paper-discord-badge"
+ className="site-discord-link"I verified This is a one-line, no-behavior-change cleanup — no correctness bugs, no provider/model/route safety concerns (not applicable to this file), no reuse/duplication issues, and no new behavior requiring test coverage. Nothing else to flag. Verified
Looks good to merge. |
|
Closing as superseded: the substantive copy, navigation, locale, and metadata improvements from this lane are already on main (5bdfeb7 localized navigation, eb5faf7 EN copy + icon buttons + locale rewrites, 74b5192 accessibility/structured-data/metadata fixes). The only remaining diff is the non-behavioral Discord badge-class cleanup, which isn't worth a merge on its own — it can ride along with the next web PR if it still matters. Thanks for keeping the web surface moving! |
Summary
Current main already contains the substantive copy, locale, navigation, and metadata improvements from the original branch. Rebuilding the PR cleanly left one honest cleanup: remove the stale
paper-discord-badgeclass from the Discord nav button, whose styling is fully owned bysite-discord-link.Validation
npm run lint -- components/nav.tsxgit diff --check origin/main...HEADNo-Issue: tiny cleanup found while rebuilding the older web branch on current main.
Agent-assisted; verified against current web styles.