Repository navigation
fix(extension): apply acknowledged mode clicks - #25
Merged
Merged
Conversation
HeftyKoo
marked this pull request as ready for review
October 19, 2026 10:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mode buttons could remain in the previous mode when the background broadcast was missed, even though
mode.setsucceeded. Apply the acknowledged mode to the current page, ignore older click replies and replies superseded by keyboard/open commands, and preserve newer session, connection and opacity state.Add regression coverage for page body replacement without broadcasts, out-of-order acknowledgements, and keyboard precedence/failed replies. Record native Arc verification and the local Pi notification repair: the Pi observer was missing and has been installed locally; no host code change is included for that configuration issue. Hot reload itself was not established as the trigger.
Update the DSH smoke test to support both the older API-key onboarding and DSH 0.2.1-rc.2's account-first dialog, including its account-menu Settings entry. The native plugin settings and authenticated API assertions remain required.
Validation: 386 tests passed with one existing optional skip; TypeScript, architecture/privacy checks, Chrome build and
git diff --checkpassed. In Arc, real Pi completions notified in Watch and returned to the correct terminal; mode clicks worked after body replacement, and a second turn notified after full page reload. The native DSH 0.2.1-rc.2 plugin smoke test passed after reproducing the old onboarding timeout.