Repository navigation
feat(jets): accept pt as the jet magnitude - #1047
Open
AnKiT-GaRG2 wants to merge 1 commit into
Open
AnKiT-GaRG2 wants to merge 1 commit into
AnKiT-GaRG2 wants to merge 1 commit into
Conversation
Jets took their length from energy or et only. Also accept pt so event data that stores transverse momentum does not have to put it in an energy field. energy is still used first, then et, then pt. Documented in the event data format guide and covered by a test. Refs HSF#350 Signed-off-by: Ankit Garg <146389256+AnKiT-GaRG2@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #350
Jets took their length from
energyoretonly, so event data that stores pT had to put it in anenergyfield. This also acceptspt:energyis used first, thenet, thenpt, so existing data is unaffected.PhoenixObjects.getJetfalls back toptguides/developers/event_data_format.mddocuments the three fieldsptwhenenergyandetare absent (fails without the change)phoenix-objects.test.tspasses and prettier is clean. I haven't looked at it in the browser. This only covers the loader; whether the UI label and cut should say "energy" for pT-based jets is a separate question I left open on the issue.AI disclosure: an AI coding assistant helped prepare this change. The tests above were run locally.