Skip to content

refactor(event-display): Add schema 7 types, simplify edm4hep type definitions, and fix bugs in JSON loader - #1046

Open
apausa wants to merge 14 commits into
HSF:mainfrom
apausa:schema7
Open

refactor(event-display): Add schema 7 types, simplify edm4hep type definitions, and fix bugs in JSON loader#1046
apausa wants to merge 14 commits into
HSF:mainfrom
apausa:schema7

Conversation

@apausa

@apausa apausa commented Oct 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Derive each schema type from its previous version to reduce file complexity
  • Remove unnecessary namespace in every schema
  • Add a Types interface in every schema and link them in edm4hep.ts
  • Add schema 7 types
  • Display TrackerHit and TrackerHit3D as other particle types
  • Use absolute PDG code for SimTrackerHits
  • Define RecoMCParticleLink differences between schema 2 and 3+

apausa added 13 commits October 19, 2026 14:43
@apausa
refactor(event-display): derive schema 2 types from previous version
8c42bc3
@apausa
refactor(event-display): derive schema 3 types from previous version
832c138
@apausa
refactor(event-display): derive schema 4 types from previous version
b39bf6a
@apausa
refactor(event-display): derive schema 5 types from previous version
e3e8831
@apausa
refactor(event-display): derive schema 6 types from previous version
a372117
@apausa
refactor(event-display): remove namespace from schemas
e98265f
@apausa
refactor(event-display): add a types interface per schema
b27c335
@apausa
refactor(event-display): refactor to easily add support for new versions
ab38295
@apausa
refactor(event-display): change comment
36439e9
@apausa
refactor(event-display): add schema 7 types
41e756a
@apausa
fix(event-display): display TrackerHit and TrackerHit3D
cd12f04
@apausa
fix(event-display): use absolute PDG code
a0eaa06
@apausa
fix(event-display): add RecoMCParticleLink differences between schema…
118b068 
… 2 and 3
@apausa apausa changed the title Schema7 Simplify edm4hep type definitions, add schema 7 types, and fix bugs in JSON loader Oct 19, 2026
@github-actions

github-actions Bot commented Oct 19, 2026

Copy link
Copy Markdown

🚀 Preview deployed: http://phoenix-pr-1046.surge.sh

Built from 9920c64.

@apausa apausa changed the title Simplify edm4hep type definitions, add schema 7 types, and fix bugs in JSON loader feat(event-display): Add schema 7 types, simplify edm4hep type definitions, and fix bugs in JSON loader Oct 19, 2026
@apausa apausa changed the title feat(event-display): Add schema 7 types, simplify edm4hep type definitions, and fix bugs in JSON loader refactor(event-display): Add schema 7 types, simplify edm4hep type definitions, and fix bugs in JSON loader Oct 19, 2026

This branch was successfully deployed

1 active deployment
pull-request — 9920c646 Deployed Oct 19, 2026 by github-actions[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@apausa