Repository navigation
fix(event-display): restore cell color when disabling selection - #1045
Open
dhairyajangir wants to merge 1 commit into
Open
dhairyajangir wants to merge 1 commit into
dhairyajangir wants to merge 1 commit into
Conversation
Restore the original color of a hovered instanced calorimeter cell when selection is disabled. Reuse the existing cleanup helper so the color attribute is marked for an update and cached instance state is cleared. Add regression cases for instance indices zero and one, checking color restoration, neighboring-cell preservation and the update notification.
|
🚀 Preview deployed: http://phoenix-pr-1045.surge.sh Built from 3747a65. |
dhairyajangir
marked this pull request as ready for review
October 18, 2026 21:46
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disabling object selection while an instanced calorimeter cell is hovered leaves the cell white. Call the existing
clearInstanceHighlight()helper during shutdown to restore its saved color and clear the cached highlight.Add regressions for instance indices 0 and 1 using a real two-cell
InstancedMesh. They check original-color restoration, preservation of the neighboring cell, and the color attribute's rendering-update signal.Upstream Node 20 CI passed on the submitted head, including lint, tests, documentation coverage and the production web build (run). Smoke tests and commit/title validation also passed. Local Node 22 full-suite validation remains unsuccessful and is disclosed below. The reviewed two-file patch is unchanged after rebasing onto main
8e8761a5. On Node 22.22.1:test:ci: 659 passed, two failed, seven skipped. Core: 416 passed/two failed; UI: 243 passed/seven skipped.ColorOptions' random-color uniqueness assertion observed three distinct colors instead of four.The relevant tests, implementations, Jest configuration, manifests and lockfile match upstream. The inspected failure paths do not call the changed selection cleanup; this establishes scope, not the failures' causes. The complete codec module separately passed all 11 tests on both upstream and candidate with the original timeout. An earlier interrupted attempt also recorded the codec timeout; no completed full-suite result is inferred from it. No test timeout, assertion, dependency or CI gate was relaxed.
The successful upstream results and the unsuccessful local full-suite results are separate observations; their difference does not establish the causes of the local failures. The renderer is mocked in the selection regressions; browser/GPU appearance and the complete pointer/toggle interaction remain unverified.
AI assistance was used for investigation, implementation, tests, review and validation.