Skip to content

feat(ui-components): consolidate event and geometry browsers into dedicated browsers menu (#903) - #1044

Open
DashratRajpurohit wants to merge 1 commit into
HSF:mainfrom
DashratRajpurohit:feat/903-cleanup-phoenix-bar
Open

DashratRajpurohit wants to merge 1 commit into
HSF:mainfrom
DashratRajpurohit:feat/903-cleanup-phoenix-bar

Conversation

@DashratRajpurohit

Copy link
Copy Markdown
Contributor

Summary

Addresses #903 (Clean up Phoenix bar) by consolidating Event Browser, Collections Info, and Geometry Browser into a dedicated top-level Browsers menu (BrowsersComponent).

This declutters the Phoenix menu bar while grouping data navigation tools together and streamlining the More Information menu to focus on analysis and info panels (Info Panel, Eta-Phi Panel, and Track Kinematics).

Changes Made

  • New BrowsersComponent (app-browsers):
    • Houses app-event-browser, app-collections-info, and app-geometry-browser.
    • Accessible via a top-level menu toggle with tooltip "Browsers" and folder icon.
    • Supports [uiConfig] flags (showEventBrowser, showCollectionsInfo, showGeometryBrowser).
  • MoreInfoComponent (app-more-info):
    • Removed browser overlays and checkboxes; retains app-info-panel, app-eta-phi-panel, and app-kinematics-panel.
  • UiMenuComponent (app-ui-menu):
    • Integrated <app-browsers> directly preceding <app-more-info>.
    • Added optional showBrowsers?: boolean to UIMenuConfig and defaultUIMenuConfig (defaults to true).
    • Automatically hides the button if showBrowsers === false or if all three child browsers are disabled.
  • Module & Unit Tests:
    • Exported and registered BrowsersComponent in PhoenixUIModule and ui-menu/index.ts.
    • Added unit test suite in browsers.component.test.ts.
    • Added unit test suite in more-info.component.test.ts.

Test Plan

  • Automated tests:
    • yarn workspace phoenix-ng test packages/phoenix-ng/projects/phoenix-ui-components/lib/components/ui-menu/browsers/browsers.component.test.ts
    • yarn workspace phoenix-ng test packages/phoenix-ng/projects/phoenix-ui-components/lib/components/ui-menu/more-info/more-info.component.test.ts
    • yarn workspace phoenix-ng test packages/phoenix-ng/projects/phoenix-ui-components/lib/components/ui-menu/ui-menu.component.test.ts
    • All test suites passing in phoenix-ng and phoenix-event-display.
  • Linting and build verification:
    • prettier and eslint pass cleanly with no warnings or errors.
    • Production package build build:ui-components compiles without errors.

@github-actions

Copy link
Copy Markdown

🚀 Preview deployed: http://phoenix-pr-1044.surge.sh

Built from 8a89be7.

This branch was successfully deployed

1 active deployment
pull-request — 8a89be76 Deployed Oct 12, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant