Repository navigation
feat(ui-components): consolidate event and geometry browsers into dedicated browsers menu (#903) - #1044
Open
DashratRajpurohit wants to merge 1 commit into
Open
feat(ui-components): consolidate event and geometry browsers into dedicated browsers menu (#903)#1044DashratRajpurohit wants to merge 1 commit into
DashratRajpurohit wants to merge 1 commit into
Conversation
…icated browsers menu (HSF#903)
|
🚀 Preview deployed: http://phoenix-pr-1044.surge.sh Built from 8a89be7. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #903 (Clean up Phoenix bar) by consolidating Event Browser, Collections Info, and Geometry Browser into a dedicated top-level Browsers menu (
BrowsersComponent).This declutters the Phoenix menu bar while grouping data navigation tools together and streamlining the More Information menu to focus on analysis and info panels (Info Panel, Eta-Phi Panel, and Track Kinematics).
Changes Made
BrowsersComponent(app-browsers):app-event-browser,app-collections-info, andapp-geometry-browser."Browsers"and folder icon.[uiConfig]flags (showEventBrowser,showCollectionsInfo,showGeometryBrowser).MoreInfoComponent(app-more-info):app-info-panel,app-eta-phi-panel, andapp-kinematics-panel.UiMenuComponent(app-ui-menu):<app-browsers>directly preceding<app-more-info>.showBrowsers?: booleantoUIMenuConfiganddefaultUIMenuConfig(defaults totrue).showBrowsers === falseor if all three child browsers are disabled.BrowsersComponentinPhoenixUIModuleandui-menu/index.ts.browsers.component.test.ts.more-info.component.test.ts.Test Plan
yarn workspace phoenix-ng test packages/phoenix-ng/projects/phoenix-ui-components/lib/components/ui-menu/browsers/browsers.component.test.tsyarn workspace phoenix-ng test packages/phoenix-ng/projects/phoenix-ui-components/lib/components/ui-menu/more-info/more-info.component.test.tsyarn workspace phoenix-ng test packages/phoenix-ng/projects/phoenix-ui-components/lib/components/ui-menu/ui-menu.component.test.tsphoenix-ngandphoenix-event-display.prettierandeslintpass cleanly with no warnings or errors.build:ui-componentscompiles without errors.