feat(desktop): import VS Code color themes - #207
Open
lihuiyang1024 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #152.
Implements the bounded VS Code theme-import contract agreed in the issue: one local standalone JSON/JSONC color-theme file, no package discovery or include traversal, mapped into the existing Appearance theme system.
Behavior
importedis a regularThemePreferenceand usesdata-theme="imported"colorsvalues must use VS Code's hexadecimal color notationincludechains produce a visible error without replacing the current themetokenColors, extension packages, and include resolution are deliberately outside this first versionChanges Made
tokens.cssin tests so they cannot drift or become incompletedesktop/README.mdVerification
npm run typechecknpm run lintnpm test— 32 files, 207 tests passednpm run buildChecklist