Skip to content

Claude/review esp32 thread code es kdn #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GuvHas merged 2 commits into from
Mar 20, 2026
Merged

Claude/review esp32 thread code es kdn #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab1e9ed
sdkconfig.defaults: set product name to "GH LK Control"
claude Mar 20, 2026
e79c0ef
app_main: select external antenna via GPIO03/GPIO14 at startup
claude Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions main/app_main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#include <driver/gpio.h>
#include <esp_err.h>
#include <esp_log.h>
#include <esp_matter.h>
Expand Down Expand Up @@ -414,6 +415,13 @@ void app_event_cb(const ChipDeviceEvent *event, intptr_t arg)

extern "C" void app_main()
{
// Select the external antenna.
// GPIO03 low + GPIO14 high routes the RF switch to the U.FL connector.
gpio_set_direction(GPIO_NUM_3, GPIO_MODE_OUTPUT);
gpio_set_direction(GPIO_NUM_14, GPIO_MODE_OUTPUT);
gpio_set_level(GPIO_NUM_3, 0);
gpio_set_level(GPIO_NUM_14, 1);

// General-purpose NVS partition: auto-erased on unrecoverable corruption.
// Holds only non-Matter app state; safe to wipe because all Matter
// credentials live on the protected nvs_matter partition.
Expand Down
3 changes: 3 additions & 0 deletions sdkconfig.defaults
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,9 @@ CONFIG_ENABLE_WIFI_STATION=n
# under marginal RF conditions. pdMS_TO_TICKS() in app code is unaffected.
CONFIG_FREERTOS_HZ=1000

# Matter device product name shown in Home Assistant and other controllers.
CONFIG_DEVICE_PRODUCT_NAME="GH LK Control"

# Matter + logging defaults
CONFIG_ESP_MATTER_ENABLE_DATA_MODEL=y
# Canonical integer form for the log-level choice (2 = INFO)
Expand Down