Repository navigation
chore(deps): constrain test-scope Tomcat to 10.1.61 past GHSA-f525-44xv-f2qj - #58
Merged
Merged
Conversation
…xv-f2qj The Boot 3.5.16 BOM manages tomcat-embed-core, -el and -websocket at 10.1.55, which carries GHSA-f525-44xv-f2qj (CVSS 9.8, fixed in 10.1.59) and three more advisories the config suppressed. A testImplementation constraint moves the three modules to 10.1.61, the lock changes only those three lines, and the three Tomcat suppressions come out of osv-scanner.toml in the same change, as its header asks once the dependency moves. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E28c6iftj4hRmx55Uaaoxc Entire-Checkpoint: 01M6FARB3G4EA27Z272N75MDC9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The osv-scanner job is red on master: the Boot 3.5.16 BOM manages tomcat-embed-core at 10.1.55, and GHSA-f525-44xv-f2qj (CVSS 9.8, fixed in 10.1.59) has no suppression. That is the Dependency audit failure on #57.
Tomcat is test scope only (spring-boot-starter-web under testImplementation) and not in the adapter POM, so a
testImplementationconstraint moves tomcat-embed-core, -el and -websocket to 10.1.61. OSV lists no advisory for any of the three at 10.1.61, and 10.1.55 also carried GHSA-9xv2-5v5q-p794, GHSA-gcx9-497g-6cp6 and GHSA-h3x4-894j-xpx5, which the config suppressed. Those three suppressions come out ofosv-scanner.tomlin this PR, as its header asks once the dependency moves.gradle.lockfilechanges only the three Tomcat lines.Locally, osv-scanner v2.6.0 (the CI binary's release, checksum checked) with the CI command reports "No issues found" here and fails on master with GHSA-f525-44xv-f2qj. Gradle resolves
testCompileClasspathandtestRuntimeClasspathagainst the lock with no failures, while the old 10.1.55 lines with the constraint in place fail resolution. spotlessCheck, detekt andbuild -x testpass. I didn't run the tests here because they hard-codelocalhost:6379, so this PR's own build job is the test run.