Repository navigation
ci: add the ci gate job that master-rule requires - #53
Merged
Merged
Conversation
master-rule has required a status context named ci, but no job here was called ci, so the check never reported and every merge leaned on the admin bypass. The new job needs every other job in ci.yml, always runs, and fails if any of them failed or was cancelled. A skipped job counts as passed. The PHP lint step now reads find's output with a null-delimited while loop, so actionlint's shellcheck pass (SC2044) is clean on this file too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E28c6iftj4hRmx55Uaaoxc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
master-rule requires a status check called
ci, but no job in this repo was namedci, so that check never reported and every merge needed the admin bypass to get past it.This adds a
cijob at the end of.github/workflows/ci.yml. It needs every other job in the file, runs withif: always(), and fails when any of them failed or was cancelled. A skipped job counts as passed.It also switches the PHP lint step from
for f in $(find ...)to a null-delimitedwhile readloop, because actionlint's shellcheck pass flagged the old one (SC2044). Same behavior: I ran the new loop on a tree with a file that doesn't parse (exit 1) and on a clean one, with a space in a file name (exit 0,LINT_OK).actionlintis clean on the file. I also checked the gate's pass rule on its own:success success,success skippedandskipped skippedexit 0,success failureandcancelled successexit 1. The real proof is this PR's own checks, wherecihas to show up and pass.