Add remaining Hunter methods: box traps, deadfalls, magic boxes, falconry and kebbit tracking - #1239
Open
HarleyGilpin wants to merge 23 commits into
Open
Add remaining Hunter methods: box traps, deadfalls, magic boxes, falconry and kebbit tracking#1239HarleyGilpin wants to merge 23 commits into
HarleyGilpin wants to merge 23 commits into
Conversation
This was referenced Aug 31, 2026
HarleyGilpin
changed the title
HarleyGilpin
force-pushed
the
feat/skill/hunter-traps
branch
from
August 31, 2026 01:31
54cddd2 to
ffdc298
Compare
…d into feat/skill/hunter-traps
GregHib
requested changes
Sep 2, 2026
GregHib
left a comment
GregHib
left a comment
Owner
There was a problem hiding this comment.
I think chinchompa's should be able to walk over boxes
- Torch item id was torch_lit (doesn't exist) instead of lit_torch, so smoking any trap silently fell through to noInterest() - Ground traps had default collision, blocking NPCs from walking onto them (chinchompas couldn't approach a box trap) - Deadfall dismantle played the snare pickup anim instead of the boulder lay anim, and setting a boulder trap incorrectly stepped the player away from an object they were never standing on - Falconry catch kept walking the player toward the kebbit after the falcon was already thrown; leaving the area also left an unclaimed caught kebbit on the ground - Falconry area's north boundary cut through Matthias's house, so players lost their falcon mid-room; extended it to the house's actual extent - Inspecting an unrelated burrow reset any trail already in progress; now only the trail's own burrow can restart it
…raps # Conflicts: # network/src/main/kotlin/world/gregs/voidps/network/login/protocol/encode/HintEncoder.kt
main replaced the per-index hint(npc)/clearHint(id) pair with markHint(character)/clearHinted(), so the falcon catch hint needed updating to keep compiling after merging upstream/main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes the remaining Hunter training methods (bird snares, nets, pitfalls, butterflies and implings were already in).
Box traps
Lay/Check/Dismantle/Investigate on
box_trap, sharing the bird snare lifecycle. Catches grey/carnivorous chinchompas, ferret (Eagles' Peak-gated), pawya and grenwall (bait-gated with papaya/raw pawya meat).Deadfall traps
Set-trap on a boulder with knife + logs (level 23). Catches wild, barb-tailed, prickly and sabre-toothed kebbits. Logs consumed on trigger, returned on dismantle.
Magic box / imp catching
Level 71 magic box catches imps only. Imp-in-a-box supports Talk-to dialogue and Bank (authentic Imp Release Negotiation Form, interface 478).
Falconry
Matthias lends a gyr falcon (Hunter 43, both hands free). Catches spotted/dark/dashing kebbits from range; falconer's gloves occupy the weapon slot for the loan's duration.
Kebbit tracking
Adds polar, common, feldip weasel, razor-backed and desert devil trails. Trail data is TOML-driven; track-decal varbits were included. Trails are session-state, cleared on logout.
Unfinished
Rabbit snaring is still being worked on.
Tests
BoxTrapTest,DeadfallTest,MagicBoxTest,FalconryTest,KebbitTrackingTest— 31 new WorldTest cases; full:game:testgreen.