Add scene editor persist commands (place/remove/flush + JS5) - #1238
Open
MaatheusGois wants to merge 2 commits into
Open
Add scene editor persist commands (place/remove/flush + JS5)#1238MaatheusGois wants to merge 2 commits into
MaatheusGois wants to merge 2 commits into
Conversation
Support scene_place/scene_remove/scene_flush so client editor saves update GameObjects collision, obj-spawns.toml, and map archives via a writable CacheDelegate. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
|
A bit of separation of concerns would be good here, a command which updates an Reasoning for this is the cache is removed after startup to reduce unnecessary memory overhead as so is intentionally left out of koin to avoid runtime dependencies, adding it and the ~100MB+ of ram usage back in for what is a dev convenience isn't worth it imo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scene_place,scene_remove, andscene_flushfor the void-client scene editor.editor.obj-spawns.tomland rewrites JS5lX_Yvia a writableCacheDelegate(runtime FileCache is read-only).Cachein Koin and add the:bufferdependency needed by the encoder path; default development admin name isadmin.Test plan
./gradlew run), login as admined save demo→ console shows place + flush success (no Koin / Read only cache errors)ed save→ tile is walkable with Editor OFFdata/area/scene/editor.obj-spawns.tomlupdates and JS5 map archives change on diskMade with Cursor