Datanode: Fix detection of existing opensearch dist#26733
Merged
Conversation
todvora
approved these changes
Jul 23, 2026
todvora
left a comment
Contributor
There was a problem hiding this comment.
LGTM, work as expected. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, existing opensearch downloads in the build were detected via directory presence in a profile. Since the profile is created before any phase, it would detect the distributions even though a
cleanwould remove them immediately, causing builds on development machines to fail when usingcleanevery other time.This can be considered a temporary fix. We will adapt the whole download/patching part of OpenSearch to use a custom built package once OpenSearch 3.8.0 has been released.
Motivation and Context
/nocl
resolves regression introduced during development
How Has This Been Tested?
locally
Screenshots (if appropriate):
Types of changes
Checklist: