Skip to content

Datanode: Fix detection of existing opensearch dist#26733

Merged
todvora merged 1 commit into
masterfrom
datanode/fix-package
Jul 23, 2026
Merged

Datanode: Fix detection of existing opensearch dist#26733
todvora merged 1 commit into
masterfrom
datanode/fix-package

Conversation

@moesterheld

Copy link
Copy Markdown
Contributor

Description

Previously, existing opensearch downloads in the build were detected via directory presence in a profile. Since the profile is created before any phase, it would detect the distributions even though a clean would remove them immediately, causing builds on development machines to fail when using clean every other time.

This can be considered a temporary fix. We will adapt the whole download/patching part of OpenSearch to use a custom built package once OpenSearch 3.8.0 has been released.

Motivation and Context

/nocl
resolves regression introduced during development

How Has This Been Tested?

locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have requested a documentation update.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@moesterheld
moesterheld requested a review from todvora July 22, 2026 15:09

@todvora todvora left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, work as expected. Thanks!

@todvora
todvora merged commit bd6b03e into master Jul 23, 2026
24 checks passed
@todvora
todvora deleted the datanode/fix-package branch July 23, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants