Fix hiding the <CreateButton /> on overview pages if the user lags permissions#26731
Merged
Conversation
…rmissions ## Why 'Feat/14047 sigma rules to event definition wizard UI' moved the code to handle permissions out side of the component to treat it seperatly. With that the code no longer had access to the entityCreator.permissions and the component was renderded without permissions. That way the <CreateButton /> component was always rendered nevertheless the user did not have the right permissions. ## What We introduced a simple test which ensures that the button is hided if a user does not have the right permissions. We pass the entityCreator.permissions to the new <PermissionsWrapper />
kmerz
marked this pull request as ready for review
July 23, 2026 09:35
zeeklop
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
'Feat/14047 sigma rules to event definition wizard UI' moved the code to handle permissions out side of the component to treat it seperatly.
With that the code no longer had access to the entityCreator.permissions and the component was renderded without permissions. That way the component was always rendered nevertheless the user did not have the right permissions.
What
We introduced a simple test which ensures that the button is hided if a user does not have the right permissions.
We pass the entityCreator.permissions to the new
Fixes https://github.com/Graylog2/graylog-plugin-enterprise/issues/14849
/nocl
Types of changes
Checklist: