Catch possible ID mismatch when trying to update a view (7.0)#26729
Open
graylog-internal-actions-access[bot] wants to merge 1 commit into
Open
Catch possible ID mismatch when trying to update a view (7.0)#26729graylog-internal-actions-access[bot] wants to merge 1 commit into
7.0)#26729graylog-internal-actions-access[bot] wants to merge 1 commit into
Conversation
* catch possible ID mismatch * adding changelog * fixing comment * fixing changelog * adding test (cherry picked from commit 2cd0b30)
graylog-internal-actions-access
Bot
requested review from
boosty,
janheise,
kroepke,
luk-kaminski and
thll
July 22, 2026 09:27
janheise
marked this pull request as ready for review
July 22, 2026 09:27
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This is a backport of #26715 to
7.0.Description
This PR fixes an oversight in #26344
which we got notified by https://github.com/Graylog2/graylog2-server/security/advisories/GHSA-w997-cmqr-xrx6
We are now also making sure that for update, the ID from the entity matches the ID from the path. The ID is not enforced by the
@Validon the view entity as it's not necessary for creation. But for an update on an existing view, it is always present and our FE always puts it in the request.Motivation and Context
How Has This Been Tested?
manual testing, added a unit test
Screenshots (if appropriate):
Types of changes
Checklist: