Skip to content

Desktop: Support input from drawing tablets - #4354

Open
timon-schelling wants to merge 11 commits into
masterfrom
route-pointer-inputs
Open

Desktop: Support input from drawing tablets#4354
timon-schelling wants to merge 11 commits into
masterfrom
route-pointer-inputs

Conversation

@timon-schelling

@timon-schelling timon-schelling commented Jul 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

winit bump not 100% necessary. Some more drawing tablet edge cases have been addressed that I never saw. But might as well do the update now that i touch that code anyway. Could be separated out if that is wanted.

Everything else is pretty well described with the commit messages.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Jul 19, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 40 files

Confidence score: 5/5

  • Safe to merge after the addressed issues were fixed.

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread desktop/src/app.rs Outdated
@timon-schelling

timon-schelling commented Jul 19, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member Author

!build desktop (Run ID 29704545193)

@github-actions

github-actions Bot commented Jul 19, 2026

Copy link
Copy Markdown
📦 Mac Build Complete for 469cf48
Download binary

@github-actions

github-actions Bot commented Jul 19, 2026 •
edited
Loading

Copy link
Copy Markdown
📦 Linux Build Complete for 469cf48
Download binary
Download Flatpak

@github-actions

github-actions Bot commented Jul 19, 2026

Copy link
Copy Markdown
📦 Windows Build Complete for 469cf48
Download binary

@timon-schelling

timon-schelling commented Jul 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

PoC with future PRs using the input attributes that are passed through.
Just taking every sample here as input for a stamp with width and opacity mapped to pressure.

2026-07-19.23-46-46.mp4

0HyperCube
0HyperCube approved these changes Aug 13, 2026
View reviewed changes

@0HyperCube 0HyperCube left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; mostly just renaming some things.

Comment thread desktop/src/app.rs Outdated
window_fullscreen: bool,
window_pending_drag: bool,
pointer_position: PhysicalPosition<f64>,
pointer_lock_position: Option<PhysicalPosition<f64>>,

@0HyperCube 0HyperCube Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the pointer_lock_position not also be part of InputState?

Comment thread editor/src/messages/input_mapper/utility_types/pointer.rs
}

// TODO: Document the difference between this and EditorMouseState
// TODO: Document the difference between this and EditorPointerState

@0HyperCube 0HyperCube Aug 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this todo comment could be addressed instead of just updated? It seems like the only difference is one has ViewportPosition and one has EditorPosition.

I think that it should be reasonably easy to remove the PointerState entirely and just use the EditorPointerState (computing the other position using the viewport data which is usually available). Thoughts?

@timon-schelling timon-schelling Aug 16, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to do that in a followup but yes we should do that

@0HyperCube 0HyperCube mentioned this pull request Aug 13, 2026
Open
@timon-schelling
timon-schelling force-pushed the route-pointer-inputs branch 2 times, most recently from e5bbb02 to cd38301 Compare August 16, 2026 00:52
@timon-schelling

timon-schelling commented Aug 16, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member Author

!build desktop (Run ID 31918893822)

@github-actions

github-actions Bot commented Aug 16, 2026

Copy link
Copy Markdown
📦 Mac Build Complete for 95c5c7c
Download binary

@github-actions

github-actions Bot commented Aug 16, 2026 •
edited
Loading

Copy link
Copy Markdown
📦 Linux Build Complete for 95c5c7c
Download binary
Download Flatpak

@github-actions

github-actions Bot commented Aug 16, 2026

Copy link
Copy Markdown
📦 Windows Build Complete for 95c5c7c
Download binary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments
+1 more reviewer
@0HyperCube 0HyperCube 0HyperCube approved these changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@timon-schelling @0HyperCube