Conversation
Everything Radar draws with DrawMapInCull / DrawPOIInCull goes into the
culling window, so its rect clips the walkable map and every POI. That
rect is captured from the live ImGui window every frame while
ModifyCullWindow is on -- including when the window is COLLAPSED, where
ImGui reports just the title bar.
Found in a live session as CullWindowPos {0,0}, CullWindowSize {400,28}:
400 is the initial size this code sets via SetNextWindowSize, and 28 is
a collapsed window's title bar. With that saved, the overlay is clipped
to a sliver in the corner while every read behind it is healthy, so the
plugin looks broken for no visible reason.
It is reachable through normal use rather than by accident: the gesture
that confirms the window is a double click, and a double click on the
title bar is also ImGui's own collapse gesture. Confirming can therefore
store {W, 28} and set ModifyCullWindow = false in the same frame, and
from then on the only control that could restore it is the culling
window itself, which is no longer drawn.
Two changes: skip the capture while the window is collapsed, and repair
a degenerate rect saved by an earlier build -- without the repair,
anyone already in this state stays stuck after updating. The 64px
threshold is well below any usable culling window, and
MakeCullWindowFullScreen writes the full window size anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Everything Radar draws with DrawMapInCull / DrawPOIInCull goes into the culling window, so its rect clips the walkable map and every POI. That rect is captured from the live ImGui window every frame while ModifyCullWindow is on -- including when the window is COLLAPSED, where ImGui reports just the title bar.
Found in a live session as CullWindowPos {0,0}, CullWindowSize {400,28}: 400 is the initial size this code sets via SetNextWindowSize, and 28 is a collapsed window's title bar. With that saved, the overlay is clipped to a sliver in the corner while every read behind it is healthy, so the plugin looks broken for no visible reason.
It is reachable through normal use rather than by accident: the gesture that confirms the window is a double click, and a double click on the title bar is also ImGui's own collapse gesture. Confirming can therefore store {W, 28} and set ModifyCullWindow = false in the same frame, and from then on the only control that could restore it is the culling window itself, which is no longer drawn.
Two changes: skip the capture while the window is collapsed, and repair a degenerate rect saved by an earlier build -- without the repair, anyone already in this state stays stuck after updating. The 64px threshold is well below any usable culling window, and MakeCullWindowFullScreen writes the full window size anyway.