Move About version info to Help screen#270
Merged
Merged
Conversation
Goooler
changed the title
There was a problem hiding this comment.
Pull request overview
Consolidates “About”/version information into the Help screen by removing the standalone About entry/dialog from Home and surfacing separate App/Core version rows under Help > About.
Changes:
- Removed Home-screen About action and dialog, including
HomeViewModelstate/logic that populated it. - Added version loading to
HelpViewModeland displayed App Version + Core Version rows inHelpScreen. - Added localized string resources for the new labels across all existing
ui/homelocales.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ui/home/src/main/res/values/strings.xml | Adds app_version / kernel_version labels for Help > About rows. |
| ui/home/src/main/res/values-zh/strings.xml | Localizes new version labels (Simplified Chinese). |
| ui/home/src/main/res/values-zh-rTW/strings.xml | Localizes new version labels (Traditional Chinese - Taiwan). |
| ui/home/src/main/res/values-zh-rHK/strings.xml | Localizes new version labels (Traditional Chinese - Hong Kong). |
| ui/home/src/main/res/values-vi/strings.xml | Localizes new version labels (Vietnamese). |
| ui/home/src/main/res/values-ru/strings.xml | Localizes new version labels (Russian). |
| ui/home/src/main/res/values-ko-rKR/strings.xml | Localizes new version labels (Korean). |
| ui/home/src/main/res/values-ja-rJP/strings.xml | Localizes new version labels (Japanese). |
| ui/home/src/main/kotlin/com/github/kr328/clash/home/vm/HomeViewModel.kt | Removes About-version state and the async loader previously used by the Home About dialog. |
| ui/home/src/main/kotlin/com/github/kr328/clash/home/vm/HelpViewModel.kt | Adds version loading (app + native core) and exposes it via UiState. |
| ui/home/src/main/kotlin/com/github/kr328/clash/home/ui/HomeScreen.kt | Removes the About entry point and dialog UI from Home. |
| ui/home/src/main/kotlin/com/github/kr328/clash/home/ui/HelpScreen.kt | Adds the two version rows under the Help > About category. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HelpViewModeland expose it toHelpScreenWhy
This simplifies the Home UI and consolidates About/version details in a single place while clearly distinguishing app version from core version.
Notes for reviewers
spotlessApply,app:assembleDebug).