Skip to content

Update versions on all binaries#1973

Draft
bernot-dev wants to merge 1 commit into
mainfrom
prep-rc-all-versions
Draft

Update versions on all binaries#1973
bernot-dev wants to merge 1 commit into
mainfrom
prep-rc-all-versions

Conversation

@bernot-dev

Copy link
Copy Markdown
Collaborator
  • Bumps the release version to 0.19.0 and the corresponding component
    image tags to v0.19.0-gke.0 in charts/values.global.yaml.
  • Regenerates all Kubernetes manifests (manifests/operator.yaml,
    manifests/rule-evaluator.yaml, cmd/datasource-syncer/datasource-syncer.yaml)
    to propagate the new version.
  • Updates ops/gmpctl/prep-rc.sh to automatically align the component
    image tags (configReloader, operator, ruleEvaluator, datasourceSyncer)
    with the release version in values.global.yaml.

@bernot-dev bernot-dev requested a review from bwplotka June 26, 2026 17:14
@bernot-dev bernot-dev self-assigned this Jun 26, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the release version from 0.17.3 to 0.19.0 across Helm values and deployment manifests. It also introduces an automated step in ops/gmpctl/prep-rc.sh to ensure versioned image tags match the release version in values.global.yaml. The reviewer suggested optimizing this script by batching the yq updates into a single go tool invocation rather than running it inside a loop, which improves execution speed.

Comment thread ops/gmpctl/prep-rc.sh
Comment on lines +87 to +91
# Ensure versioned image tags match the release version.
for img in configReloader operator ruleEvaluator datasourceSyncer; do
echo "🔄 Ensuring v${CLEAN_TAG}-gke.0 on ${values_file} for ${img} tag..."
go tool -modfile="${DIR}/tools/go.mod" yq -i ".images.${img}.tag = \"v${CLEAN_TAG}-gke.0\"" "${values_file}"
done

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Invoking go tool inside a loop can be quite slow because of the overhead of resolving and invoking the toolchain multiple times. We can optimize this by constructing a single yq expression and running go tool once, while still keeping the list of images clean and maintainable.

Suggested change
# Ensure versioned image tags match the release version.
for img in configReloader operator ruleEvaluator datasourceSyncer; do
echo "🔄 Ensuring v${CLEAN_TAG}-gke.0 on ${values_file} for ${img} tag..."
go tool -modfile="${DIR}/tools/go.mod" yq -i ".images.${img}.tag = \"v${CLEAN_TAG}-gke.0\"" "${values_file}"
done
# Ensure versioned image tags match the release version.
yq_expr=""
for img in configReloader operator ruleEvaluator datasourceSyncer; do
if [[ -n "${yq_expr}" ]]; then
yq_expr="${yq_expr} | "
fi
yq_expr="${yq_expr}.images.${img}.tag = \"v${CLEAN_TAG}-gke.0\""
done
echo "🔄 Ensuring v${CLEAN_TAG}-gke.0 on ${values_file} for image tags..."
go tool -modfile="${DIR}/tools/go.mod" yq -i "${yq_expr}" "${values_file}"
References
  1. When proposing a code change, always use the GitHub 'suggestion' Markdown block and ensure it captures the correct lines. (link)

@bernot-dev bernot-dev force-pushed the prep-rc-all-versions branch from dabf288 to 10921df Compare June 26, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant