Skip to content

Update README_Jdbc_to_BigQuery.md extraFilesToStage variable descri… - #4222

Open
shuesc1 wants to merge 5 commits into
GoogleCloudPlatform:mainfrom
shuesc1:patch-1
Open

shuesc1 wants to merge 5 commits into
GoogleCloudPlatform:mainfrom
shuesc1:patch-1

Conversation

@shuesc1

@shuesc1 shuesc1 commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

…ption for clarity

Adds more information about the extraFilesToStage and file naming conventions. Issue tracking #: 419513447.

…ption for clarity

Adds more information about the `extraFilesToStage` and file naming conventions. Issue tracking #: 419513447.
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the documentation for the extraFilesToStage parameter. It provides specific details on how files from Cloud Storage and Secret Manager are handled and named within the worker's /extra_files directory, ensuring users have a clearer understanding of the expected file structure.

Highlights

  • Documentation Update: Clarified the naming conventions for files staged via the extraFilesToStage parameter in the README_Jdbc_to_BigQuery.md file.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation in v1/README_Jdbc_to_BigQuery.md to clarify how files staged via the extraFilesToStage parameter are named and stored in the /extra_files directory on the worker, distinguishing between Cloud Storage files and Secret Manager secrets. There are no review comments, so no feedback is provided.

Comment thread v1/README_Jdbc_to_BigQuery.md Outdated
@derrickaw derrickaw added the improvement Making existing code better label Oct 23, 2026
Adds changes to the upstream file that will be picked up in the README
Revert changes in downstream file
restores missing character
@codecov

codecov Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.95%. Comparing base (dc78c6f) to head (e149fd5).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4222      +/-   ##
============================================
- Coverage     56.96%   56.95%   -0.01%     
+ Complexity     7612     7611       -1     
============================================
  Files          1161     1161              
  Lines         73893    73893              
  Branches       8700     8700              
============================================
- Hits          42091    42087       -4     
- Misses        28996    29001       +5     
+ Partials       2806     2805       -1     
Components Coverage Δ
spanner-templates 84.15% <ø> (ø)
spanner-import-export 72.02% <ø> (+0.01%) ⬆️
spanner-live-forward-migration 87.79% <ø> (ø)
spanner-live-reverse-replication 80.10% <ø> (ø)
spanner-bulk-migration 88.35% <ø> (ø)
gcs-spanner-dv 86.68% <ø> (ø)
see 3 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Making existing code better size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants