[sm745052]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a more flexible way to configure private connectivity for Datastream integration tests. By replacing hardcoded connectivity strings with a system property-driven approach, the tests become more adaptable to different environment configurations without requiring code changes.

Highlights

• Configuration Parameterization: Added a new method getPrivateConnectivity() to TemplateTestBase to allow dynamic configuration of private connectivity via system properties.
• Test Refactoring: Updated numerous integration tests across Datastream-to-BigQuery, Datastream-to-Spanner, and Datastream-to-SQL modules to utilize the new getPrivateConnectivity() method instead of a hardcoded string.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[codecov]

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 56.95%. Comparing base (aea715f) to head (402ccbc).

Files with missing lines	Patch %	Lines
.../java/org/apache/beam/it/gcp/TemplateTestBase.java	0.00%	1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #3668      +/-   ##
============================================
- Coverage     56.96%   56.95%   -0.01%     
+ Complexity     8034     8031       -3     
============================================
  Files          1158     1158              
  Lines         73848    73849       +1     
  Branches       8699     8699              
============================================
- Hits          42065    42060       -5     
- Misses        28983    28988       +5     
- Partials       2800     2801       +1     

Components	Coverage Δ
spanner-templates	84.14% <ø> (-0.01%)	⬇️
spanner-import-export	72.14% <ø> (-0.03%)	⬇️
spanner-live-forward-migration	87.77% <ø> (-0.02%)	⬇️
spanner-live-reverse-replication	80.08% <ø> (-0.02%)	⬇️
spanner-bulk-migration	88.34% <ø> (-0.01%)	⬇️
gcs-spanner-dv	86.66% <ø> (-0.02%)	⬇️

Files with missing lines	Coverage Δ
.../java/org/apache/beam/it/gcp/TemplateTestBase.java	0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

This pull request has been marked as stale due to 180 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time. Thank you for your contributions.

[derrickaw]

Hi @aasthabharill, is this ready to be merged. Its been awhile. Thanks.