Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1.8.23versions to avoid incompatible duplicateappkit-commontypes.Draft: keep
NEXT_PUBLIC_LOGIN_EXISTING_WALLET_ENABLEDoff in production until QA below passes.Follow-ups addressed in 1fee3b6 (not reviewed)
getAvailableChainIds). Balances, history, token lists (Home/Send/Swap pickers), Receive, profile copy-address and WalletConnect proposal chains are filtered. An EVM-only notice is shown under the Connect Wallet button and on Receive. BTC/SVM send dialogs no longer throw when the signer is missing.ensureChain); typed data usesdomain.chainId.eth_sendTransaction(EVMSigner.submitTransaction); the wallet chooses nonce/fees and broadcasts once. Wired intosendTx/sendTxWaitForMining(receipt + Divvi tracking preserved), the widget EIP-1193 provider, WalletConnecteth_sendTransaction, and LI.FI (viem wallet client over the Reown EIP-1193 provider).signTransactionthrows a clear error for connected wallets.getAppKitinit is retryable.eth_signTransaction/eth_sendRawTransactionand EIP-5792 are not advertised for external wallets.firstnameto the GoodID link; needs verification (QA step 4). Private-key copy in Options is restricted to private-key sessions.Human QA guide
Setup: use a test deployment and test-only wallet with small balances. Set
NEXT_PUBLIC_WALLET_CONNECT_PROJECT_IDto a valid Reown project ID andNEXT_PUBLIC_LOGIN_EXISTING_WALLET_ENABLED=true; restart/redeploy. Have MetaMask (or another injected EVM wallet), optionally a mobile wallet for QR, and a second account. Do not use production funds. Use DevTools Console/Network and watch for rejected promises and failed RPCs.?login=existing_wallet(and?login=existing-wallet) makes it the default. With the flag false the option disappears. Google/SMS login unchanged.personal_sign,eth_signTypedData_v4,eth_sendTransaction) resolve via the external wallet. Pair a dApp requiring Solana/Bitcoin → rejected with the EVM-only message, no uncaught exceptions.Automated verification
yarn tsc --noEmit: clean (excluding stale.nexttypes).yarn test: 14 files / 127 tests pass. New tests: wallet-submit branch ofsendTx/sendTxWaitForMining, widget provider submit path,WalletWrapper.sendTransactionHash.yarn build: succeeds.