Skip to content

Improve Reserve swap feedback and RPC resilience; upgrade to Node 24 - #645

Draft
L03TJ3 wants to merge 2 commits into
masterfrom
reserve-and-rpc-fixes
Draft

Improve Reserve swap feedback and RPC resilience; upgrade to Node 24#645
L03TJ3 wants to merge 2 commits into
masterfrom
reserve-and-rpc-fixes

Conversation

@L03TJ3

@L03TJ3 L03TJ3 commented Oct 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

Aligned with upcoming sdk updates from this PR: GoodDollar/GoodWeb3-Mono#274

Reserve and mobile UI

  • Consume structured Reserve limit errors and the shared good-design error modal.
  • Show alternative-chain availability only when the network/Reserve feature is enabled and a fresh SDK check confirms availability; refresh checks every 15 seconds.
  • Handle both Exception and Fail transaction states for swaps and approvals, closing failed swap confirmations.
  • Remove mobile drag-to-dismiss from the shared modal while retaining its layout and opacity fade.

RPC handling

  • Use bounded fallback read-provider pools for SDK-v2 on Fuse/Celo, preserving SDK-v1’s scalar RPC configuration.
  • Apply RPC exclusions consistently across discovered, configured, cached and fallback endpoints.
  • Add regression coverage for HTTP 429 failover, exhausted providers, exclusions and provider compatibility.

Runtime

  • Upgrade CI/deployment workflows, .nvmrc, engine requirements and setup documentation to Node 24.

Dependencies and validation

  • Requires the related GoodWeb3-Mono Reserve/bridge changes and updated SDK/design packages. Replace temporary local package references before merge.
  • Read-only review completed; tests, lint and builds were not rerun against this final change-set.

L03TJ3 added 2 commits October 5, 2026 18:32
@L03TJ3
update workflows and set engine to use: node 24
9806b33
@L03TJ3
fix: improve Reserve swap feedback and RPC failover
4191c80 
- Integrate the shared Reserve limit modal and verified alternative-chain messaging.
- Handle failed swap/approval states and remove the broken mobile modal drag behavior.
- Add bounded Fuse/Celo read-RPC failover and consistent RPC exclusion filtering.
- Add provider and RPC regression tests.

This branch had an error being deployed

1 failed and 1 active deployments
preview — 4191c80f Deployed Oct 12, 2026 by L03TJ3 via preview #1071
internal — 4191c80f Deployed Oct 12, 2026 by L03TJ3 via authorize #1071
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@L03TJ3