Repository navigation
fix(ci): establish reviewed scan policy and release JWT issuer - #339
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release containers copy only the backend binary, so the YAML-only JWT issuer is absent and startup validation stops the integration stack. Pass
JWT_ISSUERthrough Compose with the existing repository issuer as its default, and add a regression check that both configuration files retain the same issuer.Establish the reviewed Gitleaks base policy before the pending branch integration. It extends the default rules and exempts only the public RFC 6455 §1.3 WebSocket nonce when its exact extracted value,
internal/middleware/login_test.gopath andgeneric-api-keyrule all match (condition = "AND"). This lets subsequent PRs scan against an already-reviewed base policy rather than approving their own exceptions. Reference: https://www.rfc-editor.org/rfc/rfc6455#section-1.3 and https://github.com/gitleaks/gitleaks#configuration.Validation: 18 release tooling Python tests passed; Gitleaks 8.30.1 scanned this commit with default rules extended by the policy and found no leaks. A full current-main directory scan still reports four existing findings in
env.exampleanddeploy/kubernetes/config; they are not exempted here and are removed by the pending integration changes. The PR changes only these three files and leaves those findings visible.