Skip to content

fix(daemon): wait on tracked workers in TestPoolDrainKillsStraggler (#919) #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cairn-intern wants to merge 1 commit into from
Closed

fix(daemon): wait on tracked workers in TestPoolDrainKillsStraggler (#919) #974

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion internal/daemon/pool_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,9 @@ func TestPoolDrainKillsStraggler(t *testing.T) {
_, _ = pool.Run(context.Background(), WorkerSpec{Session: "a"}, &collectSink{})
close(runDone)
}()
waitFor(t, func() bool { return pool.QueueDepth() == 1 })
// Drain reads p.active (exposed as WorkerStats), not QueueDepth/slot occupancy.
// QueueDepth can become 1 before track(), so Drain would take the n==0 early return.
waitFor(t, func() bool { return len(pool.WorkerStats()) == 1 })

pool.Drain() // KillTimeout elapses, straggler is force-killed
if atomic.LoadInt32(&straggler.killed) != 1 {
Expand Down