Skip to content

Bump android-ci pin so Sonar analyses develop - #1843

Merged
aleksandar-apostolov merged 4 commits into
developfrom
ci/bump-android-ci-sonar-on-push
Sep 22, 2026
Merged

aleksandar-apostolov merged 4 commits into
developfrom
ci/bump-android-ci-sonar-on-push

Conversation

@aleksandar-apostolov

@aleksandar-apostolov aleksandar-apostolov commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Goal

Refs AND-1443

SonarCloud last analysed this repo's develop on 2025-12-19. The Sonar step in the
shared workflow is gated on a pull_request field that is empty on push, so it has
only ever run on PRs and never refreshes the branch baseline. Every PR gate here
measures new code against that frozen baseline.

Implementation

Bump the android-ci.yml pin in .github/workflows/android.yml to pick up
GetStream/stream-build-conventions-android#78. No other pin touched.

Testing

actionlint .github/workflows/android.yml — clean.

Draft until #78 merges. It is currently pinned to that PR's branch commit
(2e7e495). The conventions repo squash-merges and cuts version tags — the previous
pin 8b36d37d is v0.14.0 — so this must be re-pinned to the new release before it
can merge. Expect a large one-off issue count on the first clean develop analysis;
that is the backlog becoming visible, not a regression.

Summary by CodeRabbit

  • Chores
    • Updated the Android build and validation workflow to use a newer shared configuration.
    • Existing triggers, permissions, concurrency settings, and secrets remain unchanged.

Picks up the Sonar step fix from stream-build-conventions-android#78.
Until it lands, SonarCloud's develop baseline for this repo is frozen at
2025-12-19 and every PR gate measures new code against it.
@aleksandar-apostolov aleksandar-apostolov added the pr:ci CI / GitHub Actions / workflow updates label Sep 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled, or the PR is bot-authored.
  • An issue is linked (Linear ticket or GitHub issue), or the PR is bot-authored.

🎉 Great job! This PR is ready for review.

@github-actions

github-actions Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

SDK Size Comparison 📏

SDK Before After Difference Status
stream-video-android-core 12.40 MB 12.41 MB 0.02 MB 🟢
stream-video-android-ui-xml 5.68 MB 5.68 MB 0.00 MB 🟢
stream-video-android-ui-compose 6.25 MB 6.23 MB -0.02 MB 🚀

@aleksandar-apostolov
aleksandar-apostolov marked this pull request as ready for review September 21, 2026 08:43
@aleksandar-apostolov
aleksandar-apostolov requested a review from a team as a code owner September 21, 2026 08:43
@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: faf9ccd0-4595-4443-a92a-536599adbff7

📥 Commits

Reviewing files that changed from the base of the PR and between 49a9d83 and 9bd1a15.

📒 Files selected for processing (1)
  • .github/workflows/android.yml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Walkthrough

The Android CI workflow now references a newer commit of the shared stream-build-conventions-android reusable workflow. Job permissions, concurrency, triggers, and secrets remain unchanged.

Changes

Android CI

Layer / File(s) Summary
Update reusable workflow reference
.github/workflows/android.yml
The base-android-ci job now references commit 2e7e495bdf40615015a775812d606c034274e10a of the shared Android CI workflow.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: gpunto

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: updating the Android CI pin to enable Sonar analyses on develop.
Description check ✅ Passed The description includes the goal, implementation details, testing result, related issue, draft status, and required follow-up. UI, checklist, and reviewer sections are omitted, but they are not criti…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit hops through checks anew
The Android workflow points to two
A pinned commit, neat and bright
Keeps the build path locked just right
CI ears twitch: all green in sight

Comment @coderabbitai help to get the list of available commands.

@rahul-lohra rahul-lohra left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aleksandar-apostolov
aleksandar-apostolov enabled auto-merge (squash) September 22, 2026 14:00
stream-build-conventions-android#78 squash-merged as 68c8917. The previous
pin was that PR's branch commit, which carried an earlier form of the Sonar
condition and sits on a now-deleted branch.
@sonarqubecloud

Copy link
Copy Markdown

@aleksandar-apostolov
aleksandar-apostolov merged commit 8a1637b into develop Sep 22, 2026
17 checks passed
@aleksandar-apostolov
aleksandar-apostolov deleted the ci/bump-android-ci-sonar-on-push branch September 22, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:ci CI / GitHub Actions / workflow updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants