feat(feeds-client): regenerate for reaction write outcome fields - #311
JimmyPettersson85 wants to merge 1 commit into
Conversation
Regenerated from the v2 feeds clientside spec, which now carries outcome, previous_reaction_type and counter_delta on AddReactionResponse and AddCommentReactionResponse (GetStream/chat#17241). The regen also picks up everything else that landed on the chat spec since the last refresh. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (5)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Regenerates
@stream-io/feeds-clientfrom the v2 feeds clientside spec, which now carries three new fields onAddReactionResponseandAddCommentReactionResponse:outcomestring—created|replaced|unchangedprevious_reaction_typestring?enforce_uniqueremovedcounter_deltanumber—0|1Backend PR: GetStream/chat#17241 (FEEDS-1886). With
enforce_unique=truethe previous reaction is replaced silently, and nothing in the response told the caller whether the reaction was new or a swap — so a customer keeping their own per-user reaction counter had to read before writing, or delete-then-add.Counting recipe:
add → outcome === 'created' ? +1 : 0;delete → 2xx ? -1 : 0.Merge order
Merges before the backend, per the usual flow: SDKs merge and release first, then the chat repo bumps its pinned SDK versions, then GetStream/chat#17241 merges.
Generated from that PR's branch spec, so if its API surface changes during review this needs regenerating before release.
Notes
The diff is larger than the three fields because
src/genwas last refreshed against an older chat spec, so this also picks up everything that landed since.Generated against the chat PR branch's
releases/v2/feeds-clientside-api.yamlrather than viagenerate-openapi.sh, which hardcodesCHAT_DIR="../chat"and would have used whatever branch that sibling checkout happened to be on.Testing
yarn lint:genapplied.yarn build:clientclean —vite buildandtsc -p tsconfig.lib.jsonboth exit 0; fields confirmed present in the builtdist/types/gen/models/index.d.ts.enforce-unique.test.tsreports 25 errors against npm 2.5.0 (17 of them the three new fields) and 0 field errors against this build. The remaining 8 are a pre-existingProperty 'activity' does not exist on type 'WSEvent'gap, unrelated to this change.FEEDS_JS_SDK_BRANCHswap that was previously missing for this package.🤖 Generated with Claude Code