Skip to content

Bump android-ci pin so Sonar analyses develop - #214

Open
aleksandar-apostolov wants to merge 1 commit into
developfrom
ci/bump-android-ci-sonar-on-push
Open

aleksandar-apostolov wants to merge 1 commit into
developfrom
ci/bump-android-ci-sonar-on-push

Conversation

@aleksandar-apostolov

@aleksandar-apostolov aleksandar-apostolov commented Sep 21, 2026

Copy link
Copy Markdown
Collaborator

Goal

Refs AND-1443

SonarCloud last analysed this repo's develop on 2025-10-15. The Sonar step in the
shared workflow is gated on a pull_request field that is empty on push, so it has
only ever run on PRs and never refreshes the branch baseline. Every PR gate here
measures new code against that frozen baseline.

This repo went stale before the shared workflow existed (created 2025-12-23), and its
SONAR_TOKEN was only added 2026-04-15 — so the missing token is the likely earlier
cause, with the push gate keeping it stale since.

Implementation

Bump the android-ci.yml pin in .github/workflows/android.yml to pick up
GetStream/stream-build-conventions-android#78. No other pin touched.

Testing

actionlint .github/workflows/android.yml — clean.

Draft until #78 merges. It is currently pinned to that PR's branch commit
(2e7e495). The conventions repo squash-merges and cuts version tags — the previous
pin 8b36d37d is v0.14.0 — so this must be re-pinned to the new release before it
can merge. Expect a large one-off issue count on the first clean develop analysis;
that is the backlog becoming visible, not a regression.

Summary by CodeRabbit

  • Chores
    • Updated the Android continuous integration workflow to use a newer workflow version.
    • No user-facing functionality or exported interfaces were changed.

Picks up the Sonar step fix from stream-build-conventions-android#78.
Until it lands, SonarCloud's develop baseline for this repo is frozen and
every PR gate measures new code against it.
@aleksandar-apostolov aleksandar-apostolov added the pr:ci CI changes label Sep 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled, or the PR is bot-authored.
  • An issue is linked (Linear ticket or GitHub issue), or the PR is bot-authored.

🎉 Great job! This PR is ready for review.

@github-actions

Copy link
Copy Markdown
Contributor

SDK Size Comparison 📏

SDK Before After Difference Status
stream-feeds-android-client 2.55 MB 2.55 MB 0.00 MB 🟢

@sonarqubecloud

Copy link
Copy Markdown

@aleksandar-apostolov
aleksandar-apostolov marked this pull request as ready for review September 21, 2026 12:48
@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 1b753716-61df-48eb-a772-a4372330ab61

📥 Commits

Reviewing files that changed from the base of the PR and between de13d0b and 4131523.

📒 Files selected for processing (1)
  • .github/workflows/android.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The Android CI workflow now references updated pinned conventions workflow commit 2e7e495bdf40615015a775812d606c034274e10a.

Changes

Android CI

Layer / File(s) Summary
Update Android workflow pin
.github/workflows/android.yml
The workflow now uses the updated conventions workflow commit.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: updating the Android CI pin to enable the Sonar analysis fix for develop.
Description check ✅ Passed The description includes the goal, implementation, and testing details. It explains the SonarCloud baseline issue, identifies the exact pin change, records the validation command, and notes the tempor…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the workflow pin
The Android build can now begin
One commit marks the updated way
CI hops through tests today
Ears up for a green display

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:ci CI changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant