Bump android-ci pin so Sonar analyses develop - #82
Open
aleksandar-apostolov wants to merge 1 commit into
Open
aleksandar-apostolov wants to merge 1 commit into
aleksandar-apostolov wants to merge 1 commit into
Conversation
Picks up the Sonar step fix from stream-build-conventions-android#78. Until it lands, SonarCloud's develop baseline for this repo is frozen and every PR gate measures new code against it.
Contributor
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
|
aleksandar-apostolov
marked this pull request as ready for review
September 21, 2026 12:48
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Refs AND-1443
SonarCloud last analysed this repo's
developon 2025-12-23. The Sonar step in theshared workflow is gated on a
pull_requestfield that is empty on push, so it hasonly ever run on PRs and never refreshes the branch baseline. Every PR gate here
measures new code against that frozen baseline.
Implementation
Bump the
android-ci.ymlpin in.github/workflows/android.ymlto pick upGetStream/stream-build-conventions-android#78. No other pin touched.
Testing
actionlint .github/workflows/android.yml— clean.Draft until #78 merges. It is currently pinned to that PR's branch commit
(
2e7e495). The conventions repo squash-merges and cuts version tags — the previouspin
8b36d37disv0.14.0— so this must be re-pinned to the new release before itcan merge. Expect a large one-off issue count on the first clean
developanalysis;that is the backlog becoming visible, not a regression.